-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conviva custom events #10
Conversation
# Conflicts: # conviva/src/utils/Utils.ts
🦋 Changeset detectedLatest commit: b1f71c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
conviva/package.json
Outdated
"theoplayer": "^5.0.0 || ^6.0.0", | ||
"@theoplayer/yospace-connector-web": "^2.1.0" | ||
"@theoplayer/yospace-connector-web": "^2.1.0", | ||
"theoplayer": "^5.0.0 || ^6.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add 7.0 support already since we are making a change anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! I'll add it
Update dependencies Approved-by: Joris Fluyt
Note: this PR was moved from the internal repo.