Skip to content

Bugfix/ios sync event on main thread #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wvanhaevre merged 2 commits into from
Feb 2, 2026
Merged

Bugfix/ios sync event on main thread #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07f57a
Call playerStateSync on main thread
wvanhaevre Jan 30, 2026
5b4fb18
Add changelog entry
wvanhaevre Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed an issue on iOS where the onPlayerStateSync callback was not called from the main thread.

## [10.9.0] - 26-01-29

### Fixed
Expand Down
6 changes: 4 additions & 2 deletions ios/THEOplayerRCTView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,10 @@ public class THEOplayerRCTView: UIView {
}

public func syncPlayerState() {
if let forwardedPlayerStateSync = self.onNativePlayerStateSync {
forwardedPlayerStateSync(["state": self.collectPlayerStatePayload()])
DispatchQueue.main.async {
if let forwardedPlayerStateSync = self.onNativePlayerStateSync {
forwardedPlayerStateSync(["state": self.collectPlayerStatePayload()])
}
}

// trigger different feature managers to reflect the current state
Expand Down
Loading