Open
Conversation
Contributor
Author
|
Tested in this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dryRunoption in the Bump and release workflow wasn't very dry... First, the "bump and release" job would try to commit and push a bunch of things, and then the "cleanup" job would revert those changes.Except, if "bump and release" is run as a dry run with the same version as the latest version, then the "clean up" job would remove the tag for that latest version! This happened in this run, which removed the 10.10.0 tag. We had to manually re-create that tag.
This reworks the workflow so dry runs don't push anything. Hence, they also don't need to be cleaned up, so we can't mess up the cleanup logic either. 😉