Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for math-related deprecations #59

Closed
wants to merge 5 commits into from

Conversation

Br1ght0ne
Copy link

@Br1ght0ne Br1ght0ne commented Jan 30, 2024

Because of CleverRaven/Cataclysm-DDA#71286, arithmetic and adjust_var used by this mod no longer work. I attempted to port these to math syntax as best as I could.
This is my first encounter with EOCs, so this PR might require revisions.

Incorporates time fixes from #57 (thanks @bcmcms!)

Br1ght0ne and others added 4 commits January 30, 2024 19:04
TODO: durations
Taken from TGWeaver#57,
courtesy of bcmcms.

Co-authored-by: bcmcms <bcmcms@users.noreply.github.com>
@Br1ght0ne
Copy link
Author

My bad: I did not see #55 and #57 before opening this PR. I included the patch by @bcmcms in this PR, but if any of the previous PRs get merged, I'll update my PR.

@Br1ght0ne

This comment was marked as resolved.

@DenCheesecake
Copy link

@Br1ght0ne thank you for the update! How critical are the errors related to u_val('missionswon')? Is the current build still playable with these?

Co-authored-by: ggLee <aucun6352@users.noreply.github.com>
@Br1ght0ne
Copy link
Author

Thank you @aucun6352!

Re @DenCheesecake: the build was playable, though the "missions won" number in expedition stats was broken. Now, thanks to @aucun6352, everything should work and throw no errors!

@Br1ght0ne
Copy link
Author

Handled by CleverRaven/Cataclysm-DDA#71496.

@Br1ght0ne Br1ght0ne closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants