Skip to content

Conversation

@dmitriyrepin
Copy link
Contributor

Outstanding work

  • Add more unit tests for internal functions
  • Add a test comparing expected and actual .zmetadata for the serialized dataset

@tasansal tasansal changed the title Converting MDIO dataset to XArray DataArray and wring it to ZARR Converter for MDIO dataset spec to Xarray Dataset and serialize it to Zarr Jul 14, 2025
Copy link
Contributor

@tasansal tasansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i put in lots of nitpick

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 92.46753% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (0195bb1) to head (d08e2c4).
Report is 190 commits behind head on v1.

Files with missing lines Patch % Lines
tests/unit/v1/test_dataset_serializer.py 92.62% 15 Missing and 1 partial ⚠️
src/mdio/schemas/v1/dataset_serializer.py 91.79% 3 Missing and 8 partials ⚠️
tests/unit/v1/helpers.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v1     #571      +/-   ##
==========================================
+ Coverage   84.32%   90.60%   +6.28%     
==========================================
  Files          46       72      +26     
  Lines        2194     3948    +1754     
  Branches      305      278      -27     
==========================================
+ Hits         1850     3577    +1727     
- Misses        301      304       +3     
- Partials       43       67      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tasansal tasansal merged commit d08e2c4 into TGSAI:v1 Jul 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants