-
Notifications
You must be signed in to change notification settings - Fork 16
Converter for MDIO dataset spec to Xarray Dataset and serialize it to Zarr #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…alidate* functions
tasansal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i put in lots of nitpick
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1 #571 +/- ##
==========================================
+ Coverage 84.32% 90.60% +6.28%
==========================================
Files 46 72 +26
Lines 2194 3948 +1754
Branches 305 278 -27
==========================================
+ Hits 1850 3577 +1727
- Misses 301 304 +3
- Partials 43 67 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 0447659.
Outstanding work