Repository navigation
Add invite buttons and /guild forceleader - #150
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ryanbarlow97
changed the title
Invites now end with clickable [Accept] and [Decline] chat buttons instead of a typed command hint, and guild invites name the inviter and confirm to them. /guild join and /faction join without an id accept the only pending invite, or list several with buttons. New /guild decline <id> and /faction decline <id> drop an invite and tell an online leader. Guild joins announce "joined the guild" to the realm and no longer echo to the joiner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hands a sub-guild to one of its members, like /faction forceleader does for realms. The base guild points to /faction forceleader. Tab completion offers sub-guild ids, then the guild's other members. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ryanbarlow97
force-pushed
the
guild-invite-buttons
branch
from
October 10, 2026 22:01
f51ed4b to
952db86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invites were hard to act on: a guild invite gave no hint how to accept, plain
/guild joingave the generic "Error with command format", and joining a guild announced "joined the faction"./guild joinand/faction joinwithout an id accept the only pending invite. With several invites, they list each one with its own buttons. With none, they say so./guild decline <id>and/faction decline <id>remove the invite and tell the leader if they're online./faction declinewithout an id still answers diplomatic requests.joinanddeclinesuggests the player's pending invites./guild forceleader <guild> <player>makes an existing guild member the leader, like/faction forceleaderdoes for a realm. On a realm's base guild it points you to/faction forceleader. Tab completion suggests sub-guilds, then the guild's other members.The join and decline handling moved out of
CommandManagerintoInviteCommands.mvn clean verify: 7,550 tests pass.🤖 Generated with Claude Code