Skip to content

fix: let lecterns hold written books when no project is open - #10

Merged
Drefvelin merged 1 commit into
mainfrom
fix/lectern-written-books
Oct 5, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/lectern-written-books

Conversation

@Drefvelin

Copy link
Copy Markdown
Contributor

Summary

  • A lectern with no research project now keeps vanilla book behaviour: place a written book or book and quill, and open a book already on the lectern.
  • An active project still takes the lectern. Right-click opens that station, including when the player is holding a book.
  • An empty hand does not cancel the click when the other hand holds a lectern book, so that book can still be placed.

Test plan

  • Development build on the pull request succeeds, including unit tests and the runtime JAR check.
  • Right-click an empty lectern with a written book and confirm it is placed.
  • Right-click that lectern to read the book, then take it back out.
  • Right-click an empty lectern with a research paper and confirm a project still starts.
  • Right-click a lectern that already has a project and confirm the research menu still opens.

Made with Cursor

Research cancelled every lectern click, so a written book could not be placed or read on a lectern that was not already a station.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c2a174f2-4602-4527-bbc3-c915ac8c767b
📥 Commits

Reviewing files that changed from the base of the PR and between cf8151a and 2e3e43b.

📒 Files selected for processing (2)
  • src/main/java/net/tfminecraft/research/manager/ResearchManager.java
  • src/test/java/net/tfminecraft/research/manager/ResearchManagerTest.java
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit ff26ef1 into main Oct 5, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/lectern-written-books branch October 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant