Skip to content

docs: stop the test steps when dependency preparation fails #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbarlow97 merged 2 commits into from
Oct 3, 2026
Merged

docs: stop the test steps when dependency preparation fails #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5268069
docs: stop the test steps when dependency preparation fails
ryanbarlow97 Oct 3, 2026
26b15ea
docs: say where the TLibs installer comes from
ryanbarlow97 Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,17 @@ Install the pinned shared plugin dependencies, download the private build
inputs, then run the build with Java 21. In Bash:

```bash
python3 path/to/TLibs/tools/install-plugins.py --pom pom.xml --mode pinned
read -rsp 'ServerAssets token: ' token && echo
GH_TOKEN="$token" bash .github/scripts/prepare-release.sh; unset token
mvn clean verify
python3 path/to/TLibs/tools/install-plugins.py --pom pom.xml --mode pinned &&
(read -rsp 'ServerAssets token: ' GH_TOKEN && echo && export GH_TOKEN &&
bash .github/scripts/prepare-release.sh) &&
Comment thread
ryanbarlow97 marked this conversation as resolved.
mvn clean verify
```

Point the installer at your TLibs checkout. The token needs Contents read access
to TF-Minecraft/ServerAssets. The prompt keeps it out of shell history, and only
the download script receives it. CI supplies it from `DEPS_TOKEN`.
The installer comes from a separate TLibs checkout
(`git clone https://github.com/TF-Minecraft/TLibs.git`); point `path/to/TLibs` at it. The token needs Contents read access
to TF-Minecraft/ServerAssets. The prompt keeps it out of shell history, the
subshell keeps it out of your session and Maven, and Maven only runs if both
preparation steps succeed. CI supplies it from `DEPS_TOKEN`.

Tests use JUnit and Mockito and run without a live Minecraft server.

Expand Down