Skip to content

fix: reword player messages in character - #25

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

Before and after

Colour codes are omitted; the code keeps them.

Before After
Shop has an invalid quantity or price. Contact the shop owner. The terms on this shop sign make no sense. Speak to the shop owner.

Testing

mvn -o verify passes: 142 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 324a4a58-5a0f-438c-988d-664e25474c8f

📥 Commits

Reviewing files that changed from the base of the PR and between aabc51b and d30591b.

📒 Files selected for processing (2)
  • src/main/java/net/tfminecraft/bartershops/ShopEvents.java
  • src/test/java/net/tfminecraft/bartershops/ShopEventsTest.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated the message shown when shop-sign terms are invalid to clarify that players should speak to the shop owner.

Walkthrough

The invalid-shop refusal message now refers to nonsensical shop-sign terms and directs the player to speak to the shop owner. The corresponding test expects the revised message. Validation and return behaviour remain unchanged.

Changes

Shop rejection message

Layer / File(s) Summary
Update rejection message
src/main/java/net/tfminecraft/bartershops/ShopEvents.java, src/test/java/net/tfminecraft/bartershops/ShopEventsTest.java
useShop displays the revised message when a shop is missing or has invalid terms. The test now expects that message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d3059

The shop rejection behavior is unchanged, and the updated test expectation matches the revised player-facing message. No actionable merge risk is evident.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 7865869 into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant