use np.expand_dims instead of np.newaxis#96
Merged
efiring merged 4 commits intoTEOS-10:masterfrom Jun 25, 2022
Merged
Conversation
7208f0c to
3723853
Compare
Member
|
Looks like there is a regression in latest pip on Windows. Getting out of build isolation did the trick for now. @efiring this PR LGTM. Do you mind taking a look and merging if you agree? |
efiring
requested changes
Jun 24, 2022
Member
efiring
left a comment
There was a problem hiding this comment.
Minor suggestions; if you disagree, it can go in as-is.
…into fix_distance_xarray
efiring
approved these changes
Jun 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
[np.newaxis, lon]is the distance function in geostrophy.py was not compatible with xarray (see exemple below). This PR fixes this issue.Exemple
outputs