[#9970] Fix failing Travis build #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madanalogy
requested changes
Feb 27, 2020
There was a problem hiding this comment.
Hello, thanks for contributing to Teammates!
If you would like to take the approach of converting npm install to npm ci, please also update the setup guide. Otherwise an alternative approach would simply be to remove npm update as the line has been made redundant since #9783.
wkurniawan07
requested changes
Feb 27, 2020
.travis.yml
Outdated
|
|
||
| jobs: | ||
| include: | ||
| - stage: "Prepare Dependencies" | ||
| name: "Prepare Dependencies" | ||
| script: | ||
| - ./gradlew downloadDependencies downloadTestDependencies downloadLinters | ||
| - npm install | ||
| - npm update | ||
| - npm ci |
There was a problem hiding this comment.
You can remove this line entirely, because this stage is meant to be caching dependencies.
tiuweehan
added a commit
to tiuweehan/teammates
that referenced
this pull request
Feb 28, 2020
* master: [TEAMMATES#9382] Add MasqueradeModeService Tests (TEAMMATES#9955) [TEAMMATES#9302] Support rich text for MCQ option text (TEAMMATES#9944) [TEAMMATES#9642] Feedback sessions with # or ? in their name can't be edited. (TEAMMATES#9925) [TEAMMATES#9970] Fix failing Travis build (TEAMMATES#9971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9970
Outline of Solution
npm updateand changenpm installtonpm ciin.travis.ymlpackage-lock.jsonto the repo by editing.gitignorenpm installtonpm ci