Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Received Responses Statistics" to "Statistics for Received Responses" #3245 #6405

Merged
merged 3 commits into from
Jan 22, 2017
Merged

Change "Received Responses Statistics" to "Statistics for Received Responses" #3245 #6405

merged 3 commits into from
Jan 22, 2017

Conversation

samsontmr
Copy link
Contributor

Fixes #3245

wkurniawan07
wkurniawan07 approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @samsontmr! May I suggest that you move to harder issues now, and leave easier ones like this to newer developers?

@wkurniawan07 wkurniawan07 self-assigned this Jan 20, 2017
@wkurniawan07 wkurniawan07 added the s.FinalReview The PR is ready for final review label Jan 20, 2017
@damithc damithc added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 21, 2017
@samsontmr
Copy link
Contributor Author

@wkurniawan07 got it!

@wkurniawan07 wkurniawan07 merged commit 89fc473 into TEAMMATES:master Jan 22, 2017
@wkurniawan07 wkurniawan07 added this to the V5.93 milestone Jan 22, 2017
xpdavid added a commit to xpdavid/teammates that referenced this pull request Jan 22, 2017
@xpdavid
Merge branch 'master' into 6396-instructor-edit-student-feedback-page…
b5304c5 
…-object

* master:
  [TEAMMATES#6320] README.md: Update users count badge to 140K (TEAMMATES#6426)
  [TEAMMATES#6354] Move logic.publicresource classes to ui.controller (TEAMMATES#6422)
  [TEAMMATES#6377] Stray closing </span> tag in questionFeedbackPathSettings.tag (TEAMMATES#6424)
  [TEAMMATES#6360] Reorganize parts of the test package (TEAMMATES#6384)
  [TEAMMATES#1426] instructorStudentComment: Give more informative status messages (TEAMMATES#6358)
  [TEAMMATES#3245] Change "Received Responses Statistics" to "Statistics for Received Responses" (TEAMMATES#6405)
  [5780] Refactor FeedbackSessionsLogic.java
karthikaacharya pushed a commit to karthikaacharya/teammates that referenced this pull request Feb 23, 2017
@samsontmr @karthikaacharya
[TEAMMATES#3245] Change "Received Responses Statistics" to "Statistic…
afdf322 
…s for Received Responses" (TEAMMATES#6405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damithc damithc damithc approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V5.93
Development

Successfully merging this pull request may close these issues.
3 participants
@samsontmr @damithc @wkurniawan07