[#12547] Empty weights for MCQ

src/main/java/teammates/common/datatransfer/questions/FeedbackMcqQuestionDetails.java

@@ -105,7 +105,7 @@ public List<String> validateQuestionDetails() {
             // trigger this error.
             if (hasAssignedWeights && !mcqWeights.isEmpty()) {
                 mcqWeights.stream()
-                        .filter(weight -> weight < 0)
+                        .filter(weight -> weight != null && weight < 0)
                         .forEach(weight -> errors.add(MCQ_ERROR_INVALID_WEIGHT));
             }
 

src/main/java/teammates/common/datatransfer/questions/FeedbackMsqQuestionDetails.java

@@ -150,7 +150,7 @@ public List<String> validateQuestionDetails() {
             // If weights are negative, trigger this error.
             if (hasAssignedWeights && !msqWeights.isEmpty()) {
                 msqWeights.stream()
-                        .filter(weight -> weight < 0)
+                        .filter(weight -> weight != null && weight < 0)
                         .forEach(weight -> errors.add(MSQ_ERROR_INVALID_WEIGHT));
             }
 

src/web/app/components/question-types/question-edit-details-form/__snapshots__/mcq-question-edit-details-form.component.spec.ts.snap

@@ -42,7 +42,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap when questionDropdownEn
           <label
             class="form-check-label ngb-tooltip-class fw-bold"
             container="body"
-            ngbtooltip="Assign weights to the choices for calculating statistics."
+            ngbtooltip="Assign weights to the choices for calculating statistics. An empty weight (i.e. Not enough information to evaluate) can be assigned by leaving the input box empty."
           >
             <input
               class="form-check-input ng-untouched ng-pristine ng-valid"
@@ -204,7 +204,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap when questionDropdownEn
           <label
             class="form-check-label ngb-tooltip-class fw-bold"
             container="body"
-            ngbtooltip="Assign weights to the choices for calculating statistics."
+            ngbtooltip="Assign weights to the choices for calculating statistics. An empty weight (i.e. Not enough information to evaluate) can be assigned by leaving the input box empty."
           >
             <input
               class="form-check-input ng-untouched ng-pristine ng-valid"
@@ -366,7 +366,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap with default view i.e.
           <label
             class="form-check-label ngb-tooltip-class fw-bold"
             container="body"
-            ngbtooltip="Assign weights to the choices for calculating statistics."
+            ngbtooltip="Assign weights to the choices for calculating statistics. An empty weight (i.e. Not enough information to evaluate) can be assigned by leaving the input box empty."
           >
             <input
               class="form-check-input ng-untouched ng-pristine ng-valid"

src/web/app/components/question-types/question-edit-details-form/mcq-question-edit-details-form.component.html

@@ -11,7 +11,7 @@
   <div class="col-md-6">
     <div class="col-md-12">
       <div class="form-check form-check-inline" *ngIf="!isGeneratedOptionsEnabled">
-        <label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
+        <label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics. An empty weight (i.e. Not enough information to evaluate) can be assigned by leaving the input box empty."
                container="body">
           <input id="weights-checkbox" class="form-check-input" type="checkbox" [ngModel]="model.hasAssignedWeights"
                  [disabled]="!isEditable"

src/web/app/components/question-types/question-edit-details-form/msq-question-edit-details-form.component.html

@@ -2,7 +2,7 @@
   <div class="col-md-6">
     <div class="col-md-12">
       <div class="form-check form-check-inline" *ngIf="!isGeneratedOptionsEnabled">
-        <label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
+        <label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics. An empty weight (i.e. Not enough information to evaluate) can be assigned by leaving the input box empty."
               container="body">
           <input id="weights-checkbox" class="form-check-input" type="checkbox" [ngModel]="model.hasAssignedWeights"
                 [disabled]="!isEditable" (ngModelChange)="triggerWeightsColumn($event)">

src/web/app/components/question-types/question-statistics/mcq-question-statistics.component.ts

@@ -62,7 +62,7 @@
       { header: 'Recipient Name', sortBy: SortBy.MCQ_RECIPIENT_NAME },
       ...Object.keys(this.weightPerOption).map((key: string) => {
         return {
-          header: `${key}[${(this.weightPerOption[key]).toFixed(2)}]`,
+          header: `${key}[${this.weightPerOption[key] !== null ? (this.weightPerOption[key]).toFixed(2) : '-'}]`,
           sortBy: SortBy.MCQ_OPTION_SELECTED_TIMES,
         };
       }),
@@ -83,8 +83,8 @@
             value: this.perRecipientResponses[key].responses[option],
           };
         }),
-        { value: (this.perRecipientResponses[key].total).toFixed(2) },
-        { value: (this.perRecipientResponses[key].average).toFixed(2) },
+        { value: this.perRecipientResponses[key].total !== null ? (this.perRecipientResponses[key].total).toFixed(2) : '-' },
+        { value: this.perRecipientResponses[key].average !== null ? (this.perRecipientResponses[key].average).toFixed(2) : '-' },
       ];
     });
   }

src/web/app/components/question-types/question-statistics/msq-question-statistics.component.ts

@@ -62,7 +62,7 @@
       { header: 'Recipient Name', sortBy: SortBy.MSQ_RECIPIENT_NAME },
       ...Object.keys(this.weightPerOption).map((key: string) => {
         return {
-          header: `${key} [${(this.weightPerOption[key]).toFixed(2)}]`,
+          header: `${key} [${this.weightPerOption[key] !== null ? (this.weightPerOption[key]).toFixed(2) : '-'}]`,
           sortBy: SortBy.MSQ_OPTION_SELECTED_TIMES,
         };
       }),
@@ -83,10 +83,9 @@
             value: this.perRecipientResponses[key].responses[option],
           };
         }),
-        { value: (this.perRecipientResponses[key].total).toFixed(2) },
-        { value: (this.perRecipientResponses[key].average).toFixed(2) },
+        { value: this.perRecipientResponses[key].total !== null ? (this.perRecipientResponses[key].total).toFixed(2) : '-' },
+        { value: this.perRecipientResponses[key].average !== null ? (this.perRecipientResponses[key].average).toFixed(2) : '-' },
       ];
     });
   }
-
 }

src/web/app/components/question-types/question-statistics/question-statistics-calculation/mcq-question-statistics-calculation.ts

@@ -61,6 +61,9 @@ export class McqQuestionStatisticsCalculation
 
       for (const answer of Object.keys(this.weightPerOption)) {
         const weight: number = this.weightPerOption[answer];
+        if (weight === null) {
+          continue;
+        }
         const frequency: number = this.answerFrequency[answer];
         const weightedPercentage: number = totalWeightedResponseCount === 0 ? 0
             : 100 * ((frequency * weight) / totalWeightedResponseCount);
@@ -94,14 +97,31 @@ export class McqQuestionStatisticsCalculation
         perRecipientResponse[response.recipient][answer] += 1;
       }
 
+      const areAllOptionWeightsNull: boolean = this.question.mcqWeights.every(weight => weight === null);
+
       for (const recipient of Object.keys(perRecipientResponse)) {
+        if (areAllOptionWeightsNull) {
+          this.perRecipientResponses[recipient] = {
+            recipient,
+            recipientEmail: recipientEmails[recipient],
+            total: null,
+            average: null,
+            recipientTeam: recipientToTeam[recipient],
+            responses: perRecipientResponse[recipient],
+          };
+          continue;
+        }
+
         const responses: Record<string, number> = perRecipientResponse[recipient];
         let total: number = 0;
         let average: number = 0;
         let numOfResponsesForRecipient: number = 0;
         for (const answer of Object.keys(responses)) {
           const responseCount: number = responses[answer];
           const weight: number = this.weightPerOption[answer];
+          if (weight === null) {
+            continue;
+          }
           total += responseCount * weight;
           numOfResponsesForRecipient += responseCount;
         }

src/web/app/components/question-types/question-statistics/question-statistics-calculation/msq-question-statistics-calculation.ts

@@ -71,6 +71,9 @@ export class MsqQuestionStatisticsCalculation
 
       for (const answer of Object.keys(this.weightPerOption)) {
         const weight: number = this.weightPerOption[answer];
+        if (weight === null) {
+          continue;
+        }
         const frequency: number = this.answerFrequency[answer];
         const weightedPercentage: number = totalWeightedResponseCount === 0 ? 0
             : 100 * ((frequency * weight) / totalWeightedResponseCount);
@@ -116,14 +119,31 @@ export class MsqQuestionStatisticsCalculation
       this.updateResponseCountPerOptionForResponse(response.responseDetails, perRecipientResponse[email]);
     }
 
+    const areAllOptionWeightsNull: boolean = this.question.msqWeights.every(weight => weight === null);
+
     for (const recipient of Object.keys(perRecipientResponse)) {
+      if (areAllOptionWeightsNull) {
+        this.perRecipientResponses[recipient] = {
+          recipient,
+          recipientEmail: recipientEmails[recipient],
+          total: null,
+          average: null,
+          recipientTeam: recipientToTeam[recipient],
+          responses: perRecipientResponse[recipient],
+        };
+        continue;
+      }
+
       const responses: Record<string, number> = perRecipientResponse[recipient];
       let total: number = 0;
       let average: number = 0;
       let numOfResponsesForRecipient: number = 0;
       for (const answer of Object.keys(responses)) {
         const responseCount: number = responses[answer];
         const weight: number = this.weightPerOption[answer];
+        if (weight === null) {
+          continue;
+        }
         total += responseCount * weight;
         numOfResponsesForRecipient += responseCount;
       }