Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate tests for SendErrorReportActionTest #13280

Merged
merged 5 commits into from
Mar 22, 2025
Merged

[#12048] Migrate tests for SendErrorReportActionTest #13280

merged 5 commits into from
Mar 22, 2025

Conversation

jasonqiu212
Copy link
Contributor

Part of #12048

@jasonqiu212 jasonqiu212 self-assigned this Mar 21, 2025
@mingyang143 mingyang143 self-requested a review March 21, 2025 06:28
mingyang143
mingyang143 reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@mingyang143 mingyang143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small nits, LGTM!

@jasonqiu212 jasonqiu212 requested a review from mingyang143 March 21, 2025 06:41
mingyang143
mingyang143 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@mingyang143 mingyang143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingyang143 mingyang143 added the s.FinalReview The PR is ready for final review label Mar 21, 2025
InfinityTwo
InfinityTwo approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@InfinityTwo InfinityTwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion that you could add if you want, but otherwise all LGTM!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 21, 2025
@jasonqiu212 jasonqiu212 merged commit 905e2bc into TEAMMATES:master Mar 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfinityTwo InfinityTwo InfinityTwo approved these changes

@mingyang143 mingyang143 mingyang143 approved these changes

Assignees

@jasonqiu212 jasonqiu212

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonqiu212 @InfinityTwo @mingyang143