Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate Tests for SearchStudentsActionTest #13269

Merged

Conversation

DhiraPT
Copy link
Contributor

@DhiraPT DhiraPT commented Mar 15, 2025

Part of #12048

Outline of Solution
Migrated SearchStudentsActionTest to use SQL-based logic instead of the previous Datastore model.

@DhiraPT DhiraPT self-assigned this Mar 15, 2025
Copy link
Contributor

@InfinityTwo InfinityTwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! just a few nits and questions/suggestions I have.

@domoberzin domoberzin added the s.Ongoing The PR is being worked on by the author(s) label Mar 22, 2025
@DhiraPT DhiraPT requested a review from InfinityTwo March 24, 2025 15:28
Copy link
Contributor

@InfinityTwo InfinityTwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@InfinityTwo InfinityTwo added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Mar 25, 2025
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@domoberzin domoberzin added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 25, 2025
@jasonqiu212 jasonqiu212 merged commit 02ade0e into TEAMMATES:master Mar 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants