-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate Tests for SearchStudentsActionTest #13269
[#12048] Migrate Tests for SearchStudentsActionTest #13269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! just a few nits and questions/suggestions I have.
src/test/java/teammates/sqlui/webapi/SearchStudentsActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/SearchStudentsActionTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part of #12048
Outline of Solution
Migrated
SearchStudentsActionTest
to use SQL-based logic instead of the previous Datastore model.