Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for GetInstructorsActionTest #13267

Merged

Conversation

mingyang143
Copy link
Contributor

Part of #12048

Outline of Solution
Change GetInstructorsAction.java to ensure compatibility with the PostgreSQL database following the database migration.

@mingyang143 mingyang143 self-assigned this Mar 15, 2025
@mingyang143 mingyang143 marked this pull request as ready for review March 15, 2025 10:33
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a fairly long test to migrate, great work!

@domoberzin domoberzin added the s.FinalReview The PR is ready for final review label Mar 22, 2025
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 23, 2025
@jasonqiu212 jasonqiu212 merged commit d788dce into TEAMMATES:master Mar 24, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants