Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for GetDeadlineExtensionActionTest #13266

Merged
merged 6 commits into from
Mar 22, 2025

Conversation

InfinityTwo
Copy link
Contributor

Part of #12048

Outline of Solution
Added the unit tests for GetDeadlineExtensionActionTest for PostgreSQL.

Copy link

Hi @InfinityTwo, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@InfinityTwo InfinityTwo changed the title Migrate tests for GetDeadlineExtensionActionTest [#12048] Migrate tests for GetDeadlineExtensionActionTest Mar 13, 2025
@InfinityTwo InfinityTwo marked this pull request as ready for review March 15, 2025 07:24
@InfinityTwo InfinityTwo self-assigned this Mar 17, 2025
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, good work!

@domoberzin domoberzin added the s.FinalReview The PR is ready for final review label Mar 22, 2025
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

params.remove(i * 2);
params.remove(i * 2);
String[] paramsArray = params.toArray(new String[0]);
verifyHttpParameterFailure(paramsArray);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 22, 2025
@jasonqiu212 jasonqiu212 merged commit c6998b3 into TEAMMATES:master Mar 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants