[#12048] Migrate tests for UpdateFeedbackResponseCommentActionTest #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test execute method with some positive and negative test cases Test checkSpecificAccessControl method with some positive and negative test cases
domoberzin
approved these changes
Mar 9, 2025
| JsonResult r = getJsonResult(action); | ||
| FeedbackResponseCommentData response = (FeedbackResponseCommentData) r.getOutput(); | ||
|
|
||
| assertEquals(updatedComment.getCommentText(), response.getCommentText()); |
There was a problem hiding this comment.
abit of a nit: this particular sequence of assertions seems quite repetitive. Perhaps it could be better to extract out into a general method to compare the response/comments/other parameters?
There was a problem hiding this comment.
@BunnyHoppp Is it possible to refactor this?
jasonqiu212
approved these changes
Mar 20, 2025
domoberzin
added
s.ToMerge
xenosf
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change UpdateFeedbackResponseCommentActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.