[#12048] Migrate tests for CreateFeedbackResponseCommentActionTest #13248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test execute method with some positive and negative test cases Test checkSpecificAccessControl method with some positive and negative test cases
…branch-CreateFeedbackResponseCommentActionTest
Test won't affect other tests that uses HibernateUtil
Followed implementation of mocking HibernateUtil in other test classes to eliminate dependencies with other tests
Removed initialisation of typicalInstructor in the field.
domoberzin
requested changes
Mar 12, 2025
src/test/java/teammates/sqlui/webapi/CreateFeedbackResponseCommentActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/CreateFeedbackResponseCommentActionTest.java
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/CreateFeedbackResponseCommentActionTest.java
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/CreateFeedbackResponseCommentActionTest.java
Show resolved
Hide resolved
Test case where instructor with only either section privilege cannot access comment.
Added that the accessControl is within grace period for better clarity
domoberzin
approved these changes
Mar 24, 2025
domoberzin
added
s.FinalReview
jasonqiu212
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change CreateFeedbackResponseCommentActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.