Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate tests for GetSessionResultsActionTest #13216

Merged
merged 7 commits into from
Mar 18, 2025
Merged

[#12048] Migrate tests for GetSessionResultsActionTest #13216

merged 7 commits into from
Mar 18, 2025

Conversation

mingyang143
Copy link
Contributor

Part of #12048

Outline of Solution
Change GetSessionResultsActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.

@mingyang143 mingyang143 force-pushed the branch-migrate-tests-week-4-2 branch from 47b048c to 199f09c Compare February 8, 2025 05:06
dishenggg
dishenggg requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!, some small changes and most of them are just changing to getTypicalXXX which should help to simply the code since we need a lot of different objects for this test and

I think we should add 2 more access control cases:

  1. Logged in as instructor with PREVIEWAS, can access
  2. Logged in as student with PREVIEWAS, cannot access

@dishenggg dishenggg added the s.Ongoing The PR is being worked on by the author(s) label Feb 19, 2025
@domoberzin
Copy link
Contributor

@mingyang143 any updates on the comments above?

dishenggg
dishenggg requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work just some small nits and we are good to merge!

@mingyang143
Copy link
Contributor Author

Hi @dishenggg , I updated the changes requested.

@mingyang143 mingyang143 requested a review from dishenggg March 13, 2025 13:04
dishenggg
dishenggg approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the work!

@dishenggg dishenggg added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Mar 17, 2025
@jasonqiu212 jasonqiu212 self-requested a review March 18, 2025 13:09
jasonqiu212
jasonqiu212 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for migrating this monster test

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 18, 2025
@jasonqiu212 jasonqiu212 merged commit 3f02f7a into TEAMMATES:master Mar 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfinityTwo InfinityTwo InfinityTwo left review comments

@dishenggg dishenggg dishenggg approved these changes

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@yuanxi1 yuanxi1 Awaiting requested review from yuanxi1

@domoberzin domoberzin Awaiting requested review from domoberzin

Assignees

@mingyang143 mingyang143

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mingyang143 @domoberzin @InfinityTwo @dishenggg @jasonqiu212