Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate Tests for FeedbackSessionClosingSoonRemindersActionTest #13211

Merged
merged 8 commits into from
Mar 26, 2025
Merged

[#12048] Migrate Tests for FeedbackSessionClosingSoonRemindersActionTest #13211

merged 8 commits into from
Mar 26, 2025

Conversation

DhiraPT
Copy link
Contributor

@DhiraPT DhiraPT commented Feb 3, 2025 •
edited
Loading

Part of #12048

Outline of Solution
Migrated FeedbackSessionClosingSoonRemindersActionTest to use SQL-based logic instead of the previous Datastore model.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Hi @DhiraPT, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@DhiraPT DhiraPT marked this pull request as draft February 19, 2025 18:40
@domoberzin
Copy link
Contributor

@DhiraPT is this ready for review?

@DhiraPT DhiraPT changed the title [#12048] Migrate Tests for FeedbackSessionClosingRemindersActionTest [#12048] Migrate Tests for FeedbackSessionClosingSoonRemindersActionTest Mar 15, 2025
@DhiraPT DhiraPT marked this pull request as ready for review March 19, 2025 06:28
@DhiraPT DhiraPT self-assigned this Mar 19, 2025
@DhiraPT
Copy link
Contributor Author

DhiraPT commented Mar 19, 2025

@DhiraPT is this ready for review?

Yes

@DhiraPT DhiraPT requested review from jasonqiu212 and removed request for dishenggg and xenosf March 22, 2025 08:43
@DhiraPT DhiraPT added the s.ToReview The PR is waiting for review(s) label Mar 23, 2025
domoberzin
domoberzin approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoberzin domoberzin added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Mar 24, 2025
jasonqiu212
jasonqiu212 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 25, 2025
@jasonqiu212 jasonqiu212 merged commit 0ccf9d5 into TEAMMATES:master Mar 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@domoberzin domoberzin domoberzin approved these changes

Assignees

@DhiraPT DhiraPT

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhiraPT @domoberzin @jasonqiu212