-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12444] Updated development.md #12525
Conversation
Update development.md
Hi @Rajdeep1311, some quick suggestions:
|
Okay I will be updating that |
[TEAMMATES#12444] Update development.md
Thanks @Rajdeep1311 for the changes! There's another reference to Could you add something similar here? Just edit the command to |
Sure |
[TEAMMATES#12444] Update development.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rajdeep1311, Thanks for the changes! Just some quick suggestions:
- As per my comments, I suggested some changes on the phrasing. Do you think they improve the clarity of the documentation?
- I believe there's another reference to
docker-compose
insearch.md
on line 19.

Like your previous changes, could you add something similar here?
Hi @Rajdeep1311, don't forget to incorporate @jasonqiu212's suggestions above! Also in |
Done !! |
Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry last few changes! Let's try to standardise how we present the alternative command (:
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #12444
Outline of Solution
Provided a clear solution for those using v1 and v2 of docker respectively.