Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11080] Support initial deployment to Java 11 runtime #11106

Merged

Conversation

wkurniawan07
Copy link
Member

@wkurniawan07 wkurniawan07 commented Apr 13, 2021

Fixes #11080

This will wrap up the first milestone of GAE runtime upgrade.

After this PR:

  • The local development environment is completely and entirely decoupled from App Engine, as evident from the commit which removes GaeSimulation (there is no GAE to be simulated anymore) and the commit that removes all App Engine dependencies.
    • Consequently, all documentation references to legacy GAE integration including usage of App Engine * APIs are updated.
    • The Cloud Code plugin for IntelliJ is no longer needed and this makes the IntelliJ setup guide moot, as it becomes a generic import-project-to-workspace instructions. As such, the guide is removed. However, we are now confident to claim that any IDE supporting Java/Gradle development will work.
  • GAE only plays a part in when deployment. This means GAE's role is now strictly platform-as-a-service, and rightly so.
  • Deployment will be targeted to Java 11 a.k.a. GAE second generation runtime.

@wkurniawan07 wkurniawan07 force-pushed the runtime-upgrade/config branch from 7511d4d to cfe048b Compare April 13, 2021 12:32
@wkurniawan07 wkurniawan07 changed the title [#11080] [WIP] Support initial deployment to Java 11 runtime [#11080] Support initial deployment to Java 11 runtime Apr 16, 2021
@wkurniawan07 wkurniawan07 added the s.ToReview The PR is waiting for review(s) label Apr 16, 2021
@wkurniawan07 wkurniawan07 requested review from rrtheonlyone, jianhandev and Derek-Hardy and removed request for rrtheonlyone April 16, 2021 18:08
@wkurniawan07 wkurniawan07 added this to the V8.0.0 milestone Apr 16, 2021
Copy link
Contributor

@Derek-Hardy Derek-Hardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wkurniawan07 wkurniawan07 requested a review from madanalogy April 19, 2021 06:20
@wkurniawan07 wkurniawan07 force-pushed the runtime-upgrade/config branch 2 times, most recently from 2d3ffc6 to 932b830 Compare April 24, 2021 03:45
@wkurniawan07 wkurniawan07 force-pushed the runtime-upgrade/config branch from 932b830 to e925514 Compare April 26, 2021 01:11
@wkurniawan07 wkurniawan07 merged commit 990f4bf into TEAMMATES:teammatesv8 Apr 26, 2021
@wkurniawan07 wkurniawan07 deleted the runtime-upgrade/config branch April 26, 2021 05:37
@wkurniawan07 wkurniawan07 added c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jun 6, 2021
daongochieu2810 pushed a commit to daongochieu2810/teammates that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants