ControllerServlet: do not sent email to admin upon error

[damithc]

Currently, an email alert is sent to the admin if a request is terminated due to an exception. This code is in the ControllerServlet. However, sending an email can delay the termination of the request which can anger GAE into shutting down the entire instance. Simply logging the error is enough because errors logged at SEVERE level generate email alerts anyway.

[LiHaoTan]

Hi, can I suggest that instead of the changes above that I make the changes as follows:

EmailWrapper errorReport =
        new EmailGenerator().generateSystemErrorEmail(requestMethod, requestUserAgent, requestPath,
                                                      requestUrl, requestParams, userType, t);
/*
 * Error report is not sent immediately as it can delay termination of request which may result
 * in GAE shutting down the instance. The error report will be sent by email in the cron job
 * auto/compileLogs later
 */
if (errorReport != null) {
    log.severe(ActivityLogEntry.generateSystemErrorReportLogMessage(req, errorReport, userType));
}