Potential incorrect sending of closing soon email

[DhiraPT]

The current query in getFeedbackSessionEntitiesPossiblyNeedingClosingSoonEmail() includes sessions where endTime > TimeHelper.getInstantDaysOffsetFromNow(-2). This means sessions that ended up to 2 days ago are still being considered, which is incorrect.

Proposed Solution:

Correct the time range condition to ensure only sessions that are actually closing soon are selected.

[jasonqiu212]

Based on the git blame here at line 559 and the discussion on #6029, I believe the -2 days is for being safe (e.g., different timezones) while achieving the goal of reducing the number of session returned.

// only get sessions with startTime within the past two days to reduce the number of sessions returned
Date d = TimeHelper.getDateOffsetToCurrentTime(-2);

But I do understand the confusion that may arise, since the current code does not contain the above comment and does not explain why it's -2. Perhaps we can clarify this by adding back the old comment?

[DhiraPT]

I also found out that if a session with previously disabled closing soon email (email was never sent before) is enabled within the 2-day limit after the session has already closed and closed email has been sent, the closing soon email will still be sent because the query only checks for isClosingSoonEmailSent and isClosingSoonEmailEnabled.