Account Request Form Upgrade

[fans2619]

This issue keeps track of PRs relating to the account request form upgrade. More info can be found on the wiki at https://github.com/TEAMMATES/teammates/wiki/Account-Request-Form-Upgrade.

[fans2619]

@damithc Good night! I just want to check a few more about the account request form. When you are adding an instructor currently, I guess you only fill in the three fields for every instructor: name, email, institution. So I wonder how you use other information provided: country, home page URL, comments/queries. Are these three for viewing only and won't be edited or stored currently?

[damithc]

@damithc Good night! I just want to check a few more about the account request form. When you are adding an instructor currently, I guess you only fill in the three fields for every instructor: name, email, institution. So I wonder how you use other information provided: country, home page URL, comments/queries. Are these three for viewing only and won't be edited or stored currently?

@fans2619 I use name | email | institution, country

url and comments/queries are used to decide if the request from a legit instructor i.e., you need to display those two to me.

[fans2619]

I use name | email | institution, country

I see. The institution, country seems a little troublesome to deal with. Personally I think you won't need to edit the country field in any way but only the country part in the institution. So I tend to show country again in the pop-up (not editable) and the institution shown can be institution, country (editable). By the way, I just came up with another question: probably we want to keep all the info submitted by a user before it's edited, e.g., original name & edited name.

url and comments/queries are used to decide if the request from a legit instructor i.e., you need to display those two to me.

So url and comments/queries will definitely be shown in a separate pop-up due to space limitation.

[damithc]

I see. The institution, country seems a little troublesome to deal with. Personally I think you won't need to edit the country field in any way but only the country part in the institution. So I tend to show country again in the pop-up (not editable) and the institution shown can be institution, country (editable). By the way, I just came up with another question: probably we want to keep all the info submitted by a user before it's edited, e.g., original name & edited name.

Need both to be editable, if the data is collected as free text. One obvious reason is to fix typos.

Currently, I don't keep the original data (but perhaps the GSheets does that anyway). I'm not sure if it is worth keeping the original data (I can't think of any use).

So url and comments/queries will definitely be shown in a separate pop-up due to space limitation.

That makes my life harder. Figure out a way to show everything without needing further clicks. The current UI can be changed as necessary. It is not very editing-friendly anyway, as you can see below (it's hard to edit when you can see only the first 10 characters of the text):

[fans2619]

Need both to be editable, if the data is collected as free text. One obvious reason is to fix typos.

Okay I think of a way. So I'll provide institution and country separately and a non-editable result showing the combination of the two (institution, country). The result will be updated automatically after you edit either institution or country, and will be used as the final institution.

Currently, I don't keep the original data (but perhaps the GSheets does that anyway). I'm not sure if it is worth keeping the original data (I can't think of any use).

Yup I can't think of any use either but it's just my habit to keep a copy of everything. I don't think it would take too much space in the database, but I'm very fine with not keeping them also, which apparently is easier to implement.

That makes my life harder. Figure out a way to show everything without needing further clicks. The current UI can be changed as necessary. It is not very editing-friendly anyway, as you can see below (it's hard to edit when you can see only the first 10 characters of the text):

I can show each account request like something below, but this will make the home page very long. So to shorten it, it may be possible to collapse requests, if you are okay with?

By the way, I just realised something. If we do not use the Google sheet, you probably won't be able to view a past request any more. It doesn't seem to be feasible to fetch and display all the requests every time when the page is loaded. So do you have any way to quickly locate a past request, either through Search or Log, or you seldom search for a past request? Myself is having some trouble with the search function, maybe caused by my setup.

[damithc]

I can show each account request like something below, but this will make the home page very long. So to shorten it, it may be possible to collapse requests, if you are okay with?

Yes, panels are OK. Again, don't make me click on a panel to see the contents (i.e., they should be expanded by default).

By the way, I just realised something. If we do not use the Google sheet, you probably won't be able to view a past request any more. It doesn't seem to be feasible to fetch and display all the requests every time when the page is loaded. So do you have any way to quickly locate a past request, either through Search or Log, or you seldom search for a past request? Myself is having some trouble with the search function, maybe caused by my setup.

Good enough if they are searchable.

[fans2619]

@damithc How does this look like? It's a simple mockup.

[damithc]

@damithc How does this look like? It's a simple mockup.

Use more realistic data e.g., the actual name/institute is likely a lot longer.

Is this the search results view or account creation page view?

[fans2619]

This is the search results. Long fields will wrap to the next line.

[fans2619]

This mockup was created manually instead of using html. I think the focus here should be on whether the Status and Options are fine.

[damithc]

This is the search results. Long fields will wrap to the next line.

I see. I assume Approve/Reject buttons are not strictly necessary as those actions are primarily done via the account creation page? If yes, can skip them to keep things simple. But if you do provide them here, the 'Edit' button should be here as well?

What does 'Reset Account Request' mean?

I think the focus here should be on whether the Status and Options are fine.

What does 'Registered' mean? Account created? If so, use 'Created' instead, so as not to confuse it with instructor joining TEAMMATES.

What's the purpose of 'Expand/Collapse All' buttons?

Less important, can be omitted in the first version:

1. We might need 'Resend' button here, in case the email doesn't go through for some reason.
2. The Submitted/Rejected/... etc. labels can use different color text (or some other styling) to easily differentiate between them.