Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - pattern matching notebook #928

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

EitanHemed
Copy link
Contributor

@EitanHemed EitanHemed commented Oct 17, 2023

Corrected EEG to ECG (electrocardiogram), the relevant term for recording the heart's electrical activity.

Also - thank you for creating/maintaining this package!

Corrected EEG to ECG (electrocardiogram), the recording of the heart's electrical activity.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seanlaw
Copy link
Contributor

seanlaw commented Oct 17, 2023

@EitanHemed Thank you for your kind words, for submitting this PR, and for correcting the mistake (I just did a search and learned that EEG is for brain waves)! I really appreciate you taking the time to do it 👍

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d569c9a) 98.93% compared to head (fb6be72) 98.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          84       84           
  Lines       14292    14292           
=======================================
  Hits        14140    14140           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanlaw seanlaw merged commit 58ccc69 into TDAmeritrade:main Oct 17, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants