Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fasthmath precision issue #1048

Merged
merged 69 commits into from
Jan 23, 2025
Merged

Fix fasthmath precision issue #1048

Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
0d4abf0
removed reassoc flag from fastmath
NimaSarajpoor Dec 5, 2024
7b9a2a3
Add reset feature to config
NimaSarajpoor Dec 22, 2024
95e7d8f
Revised config value
NimaSarajpoor Dec 22, 2024
1f95f77
replaced fastmath flags with config var
NimaSarajpoor Dec 22, 2024
37add84
fixed format
NimaSarajpoor Dec 22, 2024
c795b9d
Removed bad f-string
NimaSarajpoor Dec 22, 2024
2774302
Replaced Raised with Returns in docstring
NimaSarajpoor Dec 22, 2024
80544c7
Add second attempt for assertion
NimaSarajpoor Dec 22, 2024
a080495
minor change
NimaSarajpoor Dec 22, 2024
976ec13
Add condition to avoid revising fastmath when JIT is disabled
NimaSarajpoor Dec 22, 2024
b24ff9d
Removed support for input with type list to simplify function
NimaSarajpoor Dec 23, 2024
d13a32b
Refactored the recompile process
NimaSarajpoor Dec 24, 2024
4256839
removed blank lines
NimaSarajpoor Dec 24, 2024
f17f92d
fixed typo
NimaSarajpoor Dec 26, 2024
e543379
replaced hardcoded fastmath value with config var
NimaSarajpoor Dec 26, 2024
71fe3aa
revised function
NimaSarajpoor Dec 26, 2024
6854b0e
renamed variable to improve readability
NimaSarajpoor Dec 26, 2024
aeea9b4
fixed bug
NimaSarajpoor Dec 26, 2024
b41cc66
rename config to improve readability
NimaSarajpoor Dec 28, 2024
02b1fb4
revise func clear
NimaSarajpoor Dec 28, 2024
9647113
revise func to recompile all njit functions
NimaSarajpoor Dec 28, 2024
245bfc4
Adapt to changes in test function
NimaSarajpoor Dec 28, 2024
7dd15eb
add test
NimaSarajpoor Dec 28, 2024
4b52ff5
resolve coverage
NimaSarajpoor Dec 28, 2024
aabd41a
resolve missing lines in coverage
NimaSarajpoor Dec 28, 2024
47c9932
Add test function to improve coverage
NimaSarajpoor Dec 28, 2024
816e8d4
add fastmath module
NimaSarajpoor Dec 29, 2024
562550e
revise test function to use fastmath module
NimaSarajpoor Dec 29, 2024
d99148a
fix minor issue
NimaSarajpoor Dec 29, 2024
8a45f6e
minor change to improve readability
NimaSarajpoor Dec 29, 2024
7eb52c1
Add fastmath default flags to config default
NimaSarajpoor Jan 4, 2025
b130fa7
add reset function
NimaSarajpoor Jan 4, 2025
6264e94
rename function
NimaSarajpoor Jan 4, 2025
1d873bd
adapt recent changes in test function
NimaSarajpoor Jan 4, 2025
127e61c
minor fixes
NimaSarajpoor Jan 4, 2025
447c006
Check if DISABLE_JIT before getting fastmath
NimaSarajpoor Jan 4, 2025
14c2267
ignore lines for coverage check
NimaSarajpoor Jan 4, 2025
ec960bd
Merge branch 'main' into investigate_precision_failure
NimaSarajpoor Jan 12, 2025
2469458
Editorial fix
NimaSarajpoor Jan 12, 2025
2624445
avoid .get(key) to get KeyError if it does not exist
NimaSarajpoor Jan 12, 2025
4b37b0a
add function to save cache
NimaSarajpoor Jan 13, 2025
baf3fea
Add note to function
NimaSarajpoor Jan 13, 2025
7d02173
fix format
NimaSarajpoor Jan 13, 2025
24bc232
replace fastmath flag with config variable
NimaSarajpoor Jan 13, 2025
f5c2718
add test function to check backward compatibility
NimaSarajpoor Jan 15, 2025
1a17346
skip test when JIT is disabled
NimaSarajpoor Jan 15, 2025
995a6c2
rename test function
NimaSarajpoor Jan 16, 2025
0097953
add conditional deprecation warning
NimaSarajpoor Jan 16, 2025
bee3b63
add test function to check if cache can be saved after cache._clear()
NimaSarajpoor Jan 16, 2025
8d29f91
remove old warning
NimaSarajpoor Jan 17, 2025
18dd4b9
add test for cache._clear
NimaSarajpoor Jan 17, 2025
d7b21a7
add wrapper around private functions
NimaSarajpoor Jan 17, 2025
cf4b183
Raise OSError when NUMBA JIT is disabled during cache save
NimaSarajpoor Jan 17, 2025
89825c9
move warnings to public API
NimaSarajpoor Jan 17, 2025
6a61483
fix warning message
NimaSarajpoor Jan 17, 2025
fd7eb7d
improved warning message
NimaSarajpoor Jan 18, 2025
9ba634b
Add commit about addition config variables that are defined in __init__
NimaSarajpoor Jan 18, 2025
1a48f3d
Revise test function to improve readability
NimaSarajpoor Jan 19, 2025
02115b2
Add test function for fastmath
NimaSarajpoor Jan 19, 2025
ecaead2
Revised test functions
NimaSarajpoor Jan 19, 2025
5c1a7a7
skip test if numba JIT is disabled
NimaSarajpoor Jan 19, 2025
89db05c
omit test functions that require NUMBA JIT
NimaSarajpoor Jan 19, 2025
7e72a7f
Removed the trivial test function
NimaSarajpoor Jan 20, 2025
b82b3c9
Raise warning instead of error to avoid interrupting the program
NimaSarajpoor Jan 20, 2025
9a69593
improve readability
NimaSarajpoor Jan 21, 2025
7e5985d
remove intermediate variable
NimaSarajpoor Jan 21, 2025
2369e33
minor fixes
NimaSarajpoor Jan 21, 2025
04eac83
Add shell script code to check for harcoded fastmath flags
NimaSarajpoor Jan 23, 2025
f5186a2
minor fix on indention
NimaSarajpoor Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Editorial fix
  • Loading branch information
@NimaSarajpoor
NimaSarajpoor committed Jan 12, 2025
commit 2469458c75e181631bbb573d3a8b47932cdef19b
2 changes: 1 addition & 1 deletion stumpy/fastmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def _set(module_name, func_name, flag):

def _reset(module_name, func_name):
NimaSarajpoor marked this conversation as resolved.
Show resolved Hide resolved
"""
Reset the value of fastmath its default value
Reset the value of fastmath to its default value

Parameters
----------
Expand Down