Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added critical indexes to Message Store tables #46

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented Jul 12, 2024

  • Added critical indexes to Message Store tables
  • Changed boolean value -> string conversion to 0/1 instead to align with SQL design guidelines and have faster lookup
  • Added limits to column lengths (required by MySQL for indexed columns)
  • Removed obsolete columns in Message Store tables
  • Added QoL launch.json for VSC for one-click debugging

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (9864bea) to head (a07f6c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   87.69%   88.06%   +0.36%     
==========================================
  Files          12       12              
  Lines        1569     1617      +48     
  Branches      227      234       +7     
==========================================
+ Hits         1376     1424      +48     
  Misses        193      193              

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🥇 🥇 Clean!!!! And well documented 🙇

@thehenrytsai thehenrytsai merged commit f17e82b into main Jul 12, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/indexes branch July 12, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants