Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug where indexes are not created in MySQL #44

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Fixed bug where indexes are not created in MySQL #44

merged 4 commits into from
Jul 2, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented Jul 2, 2024 •
edited
Loading

  • Fixed bug where data store and resumable data store indexes are not created in MySQL
  • Fixed bug where silent failures occurs when creating indexes in MySQL due to not awaiting async method calls
  • Added linter rule to prevent calling async methods without await in the future
  • Consolidated dialect tests.

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.69%. Comparing base (5d1759b) to head (ae202b0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   87.45%   87.69%   +0.24%     
==========================================
  Files          12       12              
  Lines        1514     1569      +55     
  Branches      221      227       +6     
==========================================
+ Hits         1324     1376      +52     
- Misses        190      193       +3

LiranCohen
LiranCohen reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a question about commenting one ifNotExists() and not the other.

src/data-store-sql.ts Outdated Show resolved Hide resolved
src/resumable-task-store-sql.ts Outdated Show resolved Hide resolved
tests/dialect.spec.ts Outdated Show resolved Hide resolved
LiranCohen
LiranCohen previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

LiranCohen
LiranCohen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@thehenrytsai thehenrytsai merged commit 11c10cc into main Jul 2, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/if-not-exists branch July 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiranCohen LiranCohen LiranCohen approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thehenrytsai @LiranCohen