MMC5 arbitrary WRAM size support via iNES 2 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMC5 pinout supports up to 128k (4-bits x 8k), and the register interface supports up to 1MB (7-bits).
Added iNES 2 header support for MMC5 to permit arbitrary WRAM sizes. Without iNES 2 header it will fall back to previous arrangements.
Previously known sizes retain their previous arrangements even with iNES 2, so 8k and 32k bit 2 will still toggle open bus, and 16k bit 2 will still select bank. Behaviour here should not change.
Test ROMs available here: https://forums.nesdev.com/viewtopic.php?p=244062#p244062