[WIP] Improve encapsulation by passing in IEmulator when calling Bk2Movie functions
#4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all uses of
Bk2Movie.Emulatorexcept the assignment inAttach, a reference equality comparison (inDebug.Assert, for catching regressions), and a read ofbase.Emulator.FrameinTasMovie.Item[]which I left as a TODO.Should the
MovieSessionhold a reference to the core instance? I've added a prop, set at the same timeAttachwas called, but maybe it should be passed in to all those calls too.