Working examples for Lua functions emu.getregister and emu.setregister #4349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old examples were trying to use `emu.getregisters()[0]` to get an arbitrary register name for the current core. But `emu.getregisters()` returns a key–value table, not a sequential table, so it's not correct to index it with an integer. Even if it were a sequential table, the first element would be at index 1, not 0. The new examples use the Lua function `next` to get an arbitrary register name. They also replace the apparently autogenerated variable name `inemuget` with more meaningful ones (`regname` and `value`).
|
The replacement is just as unhelpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old examples were trying to use
emu.getregisters()[0]to get an arbitrary register name for the current core. Butemu.getregisters()returns a key–value table, not a sequential table, so it's not correct to index it with an integer. Even if it were a sequential table, the first element would be at index 1, not 0.The new examples use the Lua function
nextto get an arbitrary register name. They also replace the apparently autogenerated variable nameinemugetwith more meaningful ones (regnameandvalue).Check if completed: