Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I aim to implement #377. My goal is to have a checkbox in the watch editor which swaps out the address box for a freeform textbox (that's all done), into which you can type semi-arbitrary expressions involving pointer arithmetic (see below). The editor will store this with a new
Watch
subclass, which holds onto an AST of the expression (should be done modulo parsing), re-evaluating the effective address each time RAM Watch callsUpdate
(should be done modulo the peeks). Addresses are assumed to be in the sysbus, and the editor enforces this, disabling pointer mode when no sysbus exists (done).For the expressions, I plan use a C-like mixed infix/prefix syntax with:
*(0x1234 + 2 * (*0xABCD & $7))