Crash with RetroAchievements active

[ninonook1]

Summary

When Running specific roms (for this example: Super Mario Bros (E).nes) using any core (i will describe the noticable differences that happen when necessary), and having Retroachievements enabled. you would be unable to run the game.

Repro

1. Have these with you:

• bizhawk 2.11
• the rom known as 'Super Mario Bros (E).nes'
• an account connection with RetroAchievements

2. make sure RetroAchievements is activated (either during or before the result is the same)
3. launch the specified rom above
4. depending on the Preferred core being used

• QuickerNES will simply end the program
• The other two will display a black screen, essentially crashing.

Host env.

tested versions:
Bizhawk 2.11
Bizhawk 2.10
computer used:
Windows 11 AMD

[CasualPokePlayer]

The issue seems to just be due to the RCheevosAchievementForm, which is intended to be a form that displays all achievements. It was not designed well so it ends up creating a window handle for every single achievement. Super Mario Bros (E) has 1000 achievements (all unofficial anyways, but each one still gets its own form which means its own window handle) so it ends up crashing due to exhasting the window handle limit.

Ideally this form is fixed to not create its own mini form for every single achievement but I'm not sure how that is supposed to be done, so for now the feature will probably just be disabled entirely.

[ninonook1]

for the unofficial achievements or the entirety of RetroAchievements?

[CasualPokePlayer]

The entirety of RetroAchievements. The "View Achievement List" option will simply no longer be an option until this form is refactored to not used a form for every single achievement.

[Morilli]

I can't reproduce this at all. The european version of super mario bros. is actively unsupported by retroachievements (https://retroachievements.org/game/1446/hashes) and the game has nowhere near 1000 achievements that I can see, neither official ones from the website or including unofficial ones in the achievements list form (unless "Super Mario Bros (E)" refers to something else entirely?). Also, this game does not run in quickernes in the first place, not that this matters for retroachievements.

[CasualPokePlayer]

I reported that issue happened internally in RA, which it turns out those achievements were a part of some April Fools joke and have seen been removed.

If you want to reproduce the crash, Pokemon Unbound Professor Oak Challenge subset would have the next largest amount of achievements and also crashes the same.