Merged
Conversation
evaleev
requested changes
Jan 9, 2026
|
|
||
| #ifndef TAPP_TAPP_EX_IMP_H_ | ||
| #define TAPP_TAPP_EX_IMP_H_ | ||
| #ifndef REF_IMP_H_ |
Contributor
There was a problem hiding this comment.
I prefer "namespaced" header guards to avoid accidental matches to other packages ... smth like PROJECT_SUBDIR1_SUBDIR2_FILE_SUFFIX ... perhaps #pragma once now works reliably also
reference_implementation/src/error.c
Outdated
| * Umeå University - October 2024 | ||
| */ | ||
| #include "tapp_ex_imp.h" | ||
| #include <ref_imp.h> |
Contributor
There was a problem hiding this comment.
#inclusion of this project's headers should always use quotation marks ("), i.e.#include "ref_imp.h" ...
CMakeLists.txt
Outdated
| src/tapp/status.h | ||
| src/tapp/tensor.c | ||
| src/tapp/product.c | ||
| reference_implementation/include/ref_imp.h |
Contributor
There was a problem hiding this comment.
I think impl as shorthand for implementation (rather than imp) is more commonly seen
N.B. API is buildable as standalone project (so can be built in other projects).
evaleev
approved these changes
Jan 15, 2026
Contributor
evaleev
left a comment
evaleev
left a comment
There was a problem hiding this comment.
@SpaceyLake I think it's good for now, but more work is needed. @janbrandejs @devinamatthews feel free to poke also. We need to assign a version, BTW.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this branch was to separate the interface and reference implementation. Alongside that, creation functions for the handle and executor have been included in the interface, allowing tests and usecases to include tapp.h instead of the implementation-specific .h file. The .h file for the reference implementation has been renamed as well. Lastly, I deleted the Makefile since we decided to only use CMake.