chore(core-styles/cms): three small fixes/features #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(icon): hide text inside icon (TACC/Core-Styles#86) - feat(cortal.icons): collapse alias (TACC/Core-Styles#85) - fix(plugins): prevent wysiwyg css side effect (TACC/Core-CMS#575)
Same commit I just isntalled, but pin it.
wesleyboar
changed the title
wesleyboar
deleted the
bugfix/collapse-icon-alias--hide-icon-text--stop-wysiwyg-fix-side-effect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview & Related & Changes
1. Hide text inside an
<i class="icon…">accessible text</i>.Also lets us prevent CMS from stripping empty tag from WYSIWYG.
2. Add an alias
.icon-collapsefor.icon-contract.Because devs and I always expect the name to be
.icon-collapse.3. Fix a side effect from TACC/Core-CMS#573.
Another editor window had become illegible.
Testing & UI
1. Hide Icon Text
2. Icon Alias
WYSIWIG Mini-Edit Window Viewport Size Hotfix
Both viewports within the Text editor mini-windows stretch to fill and do not have overlapping text nor fields.
text.plugin.edit.windows.mov
1. & 2. Icon Tests on Portal
I added an icon—using the alias and long text inside—on the fly in the live markup.