Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/TUP-331 -- system monitor client #50

Merged
merged 15 commits into from
Sep 8, 2022

Conversation

jchuahtacc
Copy link
Contributor

@jchuahtacc jchuahtacc commented Aug 24, 2022

Overview:

System monitor

Related:

Changes:

  • System monitor client ported to typescript
  • useSystemMonitor hook
  • requests hooks (useGet, usePost) now accept a configuration object with alternate baseUrl
  • local development baseUrl is now http://localhost (as per https://github.com/TACC/tup-services/pull/13) to not conflict with tup-cms local development

Testing:

  1. Start tup-services from https://github.com/TACC/tup-services/pull/13 (localhost serves system monitor files via nginx)
  2. npx nx serve tup-cms
  3. Browse to http://localhost:8000/dashboard/login and log in.
  4. You should see the system monitor. It may take a moment or two to update

UI:

image

Notes:

@jchuahtacc jchuahtacc marked this pull request as ready for review August 24, 2022 16:24
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to review, but I failed. I do not know how to authenticate to http://localhost/sysmon/.

@@ -0,0 +1 @@
export { default } from './SystemMonitor';
Copy link
Member

@wesleyboar wesleyboar Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a 403 when I visit http://localhost/sysmon/.

I don't know what username and password to use, nor do I know where to enter that username and password.

What I Have Tried
  1. Reviewed https://github.com/TACC/tup-services/pull/5, but the README has since changed.
  2. Followed docs/ADMIN.md, and "issued" two admins, my-local-admin and [my TACC username], but I still get 403 at http://localhost/sysmon/.
  3. Used my TACC username and TACC password for dev.env and integration.env and restarted the containers, but still get a 403 at http://localhost/sysmon/.
  4. Reviewing http://localhost/docs, but mosts POSTs require a JWT.
  5. Curled /auth with my TACC username and TACC password, but received Unable to authenticate message.
  6. Curled /auth/public_key, but that gives me a public key not a JWT.

@jarosenb jarosenb merged commit 3d8fb3c into main Sep 8, 2022
@jarosenb jarosenb deleted the task/TUP-331--system-monitor-client branch September 8, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants