Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tup-ui): migrate some #196 css to core-styles #201

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 28, 2023

Overview

Migrate core-styles CSS from tup-ui app to TACC/Core-Styles.

Related

Changes

Testing

  1. Verify UI of software table and modal matches feat(tup-components): tup-448 software table #196.

UI

Remote

table modal
table modal

Local

before after (local) after (remote)
table table before table after
modal modal before modal after

Notes

Known Issues

  1. The tup-components LoginComponent styles are being loaded (inside imports-….css). I do not know why. It is related to tup-cms-react. A page without tup-cms-react (e.g. the About page) does not load an imports-….css.

@wesleyboar wesleyboar changed the title Task/tup 448 software list styles follow up core styles chore(tup-ui): migrate some #196 css to core-styles Mar 28, 2023
@wesleyboar wesleyboar marked this pull request as ready for review March 28, 2023 20:36
@wesleyboar wesleyboar merged commit f8739fc into main Mar 30, 2023
@wesleyboar wesleyboar deleted the task/tup-448-software-list-styles--follow-up-core-styles branch March 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant