Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-styles): extend root postcss config #16

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fb99d12
task/TUP-272 - core components fixup (#7)
jchuahtacc Jun 16, 2022
39ca073
task/TUP-280 -- UI patterns (#12)
jchuahtacc Jun 20, 2022
bf53fe8
task/TUP-280, 282, 283 -- UI patterns (fixes), CSS vars, styles (#14)
wesleyboar Jun 22, 2022
f4948b6
feat(core-styles): use root postcss config
wesleyboar Jun 22, 2022
a44b7be
Merge branch 'main' into milestone/001--core-components
wesleyboar Jun 24, 2022
8baf3fd
fix(core-components): missing dependency, dependency alternative (#13)
wesleyboar Jun 27, 2022
0071c50
Merge branch 'main' of github.com:TACC/tup-ui into milestone/001--cor…
jchuahtacc Jun 27, 2022
60df0dd
Merge branch 'milestone/001--core-components' of github.com:TACC/tup-…
jchuahtacc Jun 27, 2022
879717e
task/TUP - 284 -- core wrappers (#15)
jchuahtacc Jul 5, 2022
de81d57
Merge branch 'milestone/001--core-components' into milestone/001--cor…
wesleyboar Jul 6, 2022
a37a7da
fix(core-styles): load root css config after base
wesleyboar Jul 8, 2022
8e4279a
Merge branch 'main' into milestone/001--core-components
wesleyboar Jul 10, 2022
e1c776c
Merge branch 'milestone/001--core-components' into milestone/001--cor…
wesleyboar Jul 10, 2022
2bd2ac7
Merge branch 'main' into milestone/001--core-components
wesleyboar Jul 23, 2022
d3d3e69
Merge branch 'milestone/001--core-components' into milestone/001--cor…
wesleyboar Jul 23, 2022
3334f1f
Merge branch 'main' into milestone/001--core-components--core-postcss…
wesleyboar Jul 25, 2022
42c4325
Merge branch 'main' into milestone/001--core-components--core-postcss…
wesleyboar Aug 11, 2022
9891f60
Merge branch 'main' into milestone/001--core-components--core-postcss…
wesleyboar Oct 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .postcssrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ plugins:

# https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/FEATURES.md
features:
custom-properties:
# https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-custom-properties#options
preserve: false
custom-media-queries: true
media-query-ranges: true
custom-selectors: true
Expand Down
11 changes: 1 addition & 10 deletions libs/core-styles/src/.postcssrc.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,7 @@ plugins:
- 'src/lib/_themes/default.json'

postcss-preset-env:
# https://github.com/csstools/postcss-preset-env#features
stage: false

# https://github.com/csstools/postcss-preset-env/blob/master/src/lib/plugins-by-id.js#L35
features:
custom-media-queries: true
media-query-ranges: true
# RFE: Fix bug on the Internet so we can use these reliably
# SEE: https://github.com/postcss/postcss-custom-selectors/issues/40
custom-selectors: true
# managed by root

cssnano:
preset:
Expand Down
7 changes: 6 additions & 1 deletion libs/core-styles/src/bin/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const fs = require('fs');
const merge = require('merge-lite');
const yaml = require('js-yaml');

const ROOT_CONFIG_FILE = `${__dirname}/../../../../.postcssrc.yml`;
const BASE_CONFIG_FILE = `${__dirname}/../.postcssrc.base.yml`;
const NEW_CONFIG_FILE = `${__dirname}/../.postcssrc.yml`;

Expand All @@ -19,7 +20,11 @@ const NEW_CONFIG_FILE = `${__dirname}/../.postcssrc.yml`;
*/
function config(customConfigFiles = [], cssVersion) {
// Prepare data
const configFiles = [BASE_CONFIG_FILE, ...customConfigFiles];
const configFiles = [].concat(
BASE_CONFIG_FILE,
ROOT_CONFIG_FILE,
customConfigFiles
);
const configObjects = [];
let newJson;

Expand Down