chore(core-comp…): fp-1939 drop sidebar concept from section (#89)

TACC · Jan 24, 2023 · 507085d · 507085d
1 parent ec190d4
commit 507085d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 35 deletions.
diff --git a/libs/core-components/src/lib/Section/Section.jsx b/libs/core-components/src/lib/Section/Section.jsx
@@ -91,9 +91,6 @@ function Section({
   headerClassName,
   manualContent,
   manualHeader,
-  // manualSidebar,
-  // sidebar,
-  // sidebarClassName,
   messages,
 }) {
   const shouldBuildHeader = header || headerClassName || headerActions;
@@ -112,11 +109,6 @@ function Section({
       'When passing `manualHeader`, the following props are ineffectual: `header`, `headerClassName`, `headerActions`'
     );
   }
-  // if (manualSidebar && (sidebar || sidebarClassName)) {
-  //   throw new Error(
-  //     'When passing `manualSidebar`, the following props are ineffectual: `sidebar`, `sidebarClassName`'
-  //   );
-  // }
 
   useEffect(() => {
     if (bodyClassName) document.body.classList.add(bodyClassName);
@@ -129,13 +121,6 @@ function Section({
   return (
     <section className={`${styles['root']} ${className}`}>
       {messages}
-      {/* {manualSidebar ? (
-        <>{manualSidebar}</>
-      ) : (
-        <Sidebar styleName="sidebar" className={sidebarClassName}>
-          {sidebar}
-        </Sidebar>
-      )} */}
       {manualHeader ??
         (shouldBuildHeader && (
           <SectionHeader
@@ -191,10 +176,6 @@ Section.propTypes = {
   manualContent: PropTypes.oneOfType([PropTypes.bool, PropTypes.element]),
   /** The section header (built by user) element */
   manualHeader: PropTypes.element,
-  // /** The page-specific sidebar */
-  // sidebar: PropTypes.node,
-  // /** Additional className for the sidebar element */
-  // sidebarClassName: PropTypes.string,
   /** Any message(s) (e.g. <Message>) (but NOT a intro message) */
   messages: PropTypes.node,
 };
@@ -213,7 +194,6 @@ Section.defaultProps = {
   manualHeader: undefined,
   messages: '',
   introMessageName: '',
-  // sidebarClassName: '',
   introMessageText: '',
 };
 

diff --git a/libs/core-components/src/lib/SectionContent/SectionContent.jsx b/libs/core-components/src/lib/SectionContent/SectionContent.jsx
@@ -9,12 +9,6 @@ import layoutStyles from './SectionContent.layouts.module.css';
  * @enum {number}
  */
 export const LAYOUT_CLASS_MAP = {
-  /**
-   * Each child element is a full-height column with a flexible width
-   *
-   * CAVEAT: No sidebar styles provided (until a <SectionSidebar> exists)
-   */
-  hasSidebar: layoutStyles['has-sidebar'],
   /**
    * Each child element is a flexible block inside one full-height column
    */
@@ -34,7 +28,7 @@ export const LAYOUT_CLASS_MAP = {
    */
   multiColumn: layoutStyles['multi-column'],
 };
-export const DEFAULT_LAYOUT = 'hasSidebar';
+export const DEFAULT_LAYOUT = 'one-column';
 export const LAYOUTS = [...Object.keys(LAYOUT_CLASS_MAP)];
 
 /**

diff --git a/libs/core-components/src/lib/SectionContent/SectionContent.layouts.module.css b/libs/core-components/src/lib/SectionContent/SectionContent.layouts.module.css
@@ -19,14 +19,6 @@
 .root::after           { background-color: lavender; }
 */
 
-/* Has Sidebar */
-
-/* CAVEAT: No sidebar styles provided (until a <SectionSidebar> exists) */
-.has-sidebar {
-  display: flex;
-  flex-flow: row nowrap;
-}
-
 /* 1 Column */
 
 .one-column {