Skip to content

Commit

Permalink
Bump Nx to 16.5.3 (#273)
Browse files Browse the repository at this point in the history
* Bump Nx to 16.5.3

* regenerate lockfile

* satisfy type checker

* add sass dependency

* regenerate package-lock.json

* regenerate package-lock.json

* bump Nx set-shas action

* update tests to clear act warnings

* formatting

---------

Co-authored-by: Jake Rosenberg <jrosenberg@MacBook-Pro.lan>
Co-authored-by: Jake Rosenberg <jrosenberg@wireless-10-145-1-145.public.utexas.edu>
  • Loading branch information
3 people authored Aug 2, 2023
1 parent 037b2c4 commit 2ca4d01
Show file tree
Hide file tree
Showing 38 changed files with 8,531 additions and 15,131 deletions.
8 changes: 4 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nrwl/nx"],
"plugins": ["@nx"],
"overrides": [
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {
"@nrwl/nx/enforce-module-boundaries": [
"@nx/enforce-module-boundaries": [
"error",
{
"enforceBuildableLibDependency": true,
Expand All @@ -23,14 +23,14 @@
},
{
"files": ["*.ts", "*.tsx"],
"extends": ["plugin:@nrwl/nx/typescript"],
"extends": ["plugin:@nx/typescript"],
"rules": {
"@typescript-eslint/no-explicit-any": "off"
}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nrwl/nx/javascript"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
}
]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
cache: 'npm'
- run: npm ci

- uses: nrwl/nx-set-shas@v2
- uses: nrwl/nx-set-shas@v3

# Check linting/formatting of workspace files.
- run: npx nx workspace-lint
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,31 +35,31 @@ These capabilities include generating applications, libraries, etc as well as th
Below are our core plugins:

- [React](https://reactjs.org)
- `npm install --save-dev @nrwl/react`
- `npm install --save-dev @nx/react`
- Web (no framework frontends)
- `npm install --save-dev @nrwl/web`
- `npm install --save-dev @nx/web`
- [Angular](https://angular.io)
- `npm install --save-dev @nrwl/angular`
- [Nest](https://nestjs.com)
- `npm install --save-dev @nrwl/nest`
- [Express](https://expressjs.com)
- `npm install --save-dev @nrwl/express`
- [Node](https://nodejs.org)
- `npm install --save-dev @nrwl/node`
- `npm install --save-dev @nx/node`

There are also many [community plugins](https://nx.dev/community) you could add.

## Generate an application

Run `nx g @nrwl/react:app my-app` to generate an application.
Run `nx g @nx/react:app my-app` to generate an application.

> You can use any of the plugins above to generate applications as well.
When using Nx, you can create multiple applications and libraries in the same workspace.

## Generate a library

Run `nx g @nrwl/react:lib my-lib` to generate a library.
Run `nx g @nx/react:lib my-lib` to generate a library.

> You can also use any of the plugins above to generate libraries as well.
Expand All @@ -71,7 +71,7 @@ Run `nx serve my-app` for a dev server. Navigate to http://localhost:4200/. The

## Code scaffolding

Run `nx g @nrwl/react:component my-component --project=my-app` to generate a new component.
Run `nx g @nx/react:component my-component --project=my-app` to generate a new component.

## Build

Expand Down
2 changes: 1 addition & 1 deletion apps/tup-cms-react/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["plugin:@nrwl/nx/react", "../../.eslintrc.json"],
"extends": ["plugin:@nx/react", "../../.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
Expand Down
10 changes: 5 additions & 5 deletions apps/tup-cms-react/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"projectType": "application",
"targets": {
"build": {
"executor": "@nrwl/vite:build",
"executor": "@nx/vite:build",
"outputs": ["{options.outputPath}"],
"defaultConfiguration": "production",
"options": {
Expand All @@ -23,7 +23,7 @@
}
},
"serve": {
"executor": "@nrwl/vite:dev-server",
"executor": "@nx/vite:dev-server",
"defaultConfiguration": "development",
"options": {
"buildTarget": "tup-cms-react:build",
Expand All @@ -41,7 +41,7 @@
}
},
"preview": {
"executor": "@nrwl/vite:preview-server",
"executor": "@nx/vite:preview-server",
"defaultConfiguration": "development",
"options": {
"buildTarget": "tup-cms-react:build"
Expand All @@ -56,15 +56,15 @@
}
},
"test": {
"executor": "@nrwl/vite:test",
"executor": "@nx/vite:test",
"outputs": ["coverage/apps/tup-cms-react"],
"options": {
"passWithNoTests": true,
"reportsDirectory": "../../coverage/apps/tup-cms-react"
}
},
"lint": {
"executor": "@nrwl/linter:eslint",
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/tup-cms-react/**/*.{ts,tsx,js,jsx}"]
Expand Down
4 changes: 2 additions & 2 deletions apps/tup-cms-react/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": ["node"]
},
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
],
"exclude": [
"src/**/*.spec.ts",
Expand Down
4 changes: 2 additions & 2 deletions apps/tup-cms-react/tsconfig.spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"src/**/*.d.ts"
],
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
]
}
9 changes: 4 additions & 5 deletions apps/tup-cms/project.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"name": "tup-cms",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "apps/tup-cms/src/",
"projectType": "application",
Expand All @@ -8,8 +9,8 @@
"executor": "nx:run-commands",
"dependsOn": [
{
"projects": "dependencies",
"target": "build"
"target": "build",
"dependencies": true
}
],
"options": {
Expand Down Expand Up @@ -39,7 +40,6 @@
"push": {
"dependsOn": [
{
"projects": "self",
"target": "build"
}
],
Expand All @@ -63,6 +63,5 @@
"parallel": false
}
}
},
"name": "tup-cms"
}
}
2 changes: 1 addition & 1 deletion apps/tup-ui/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["plugin:@nrwl/nx/react", "../../.eslintrc.json"],
"extends": ["plugin:@nx/react", "../../.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
Expand Down
10 changes: 5 additions & 5 deletions apps/tup-ui/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"projectType": "application",
"targets": {
"build": {
"executor": "@nrwl/vite:build",
"executor": "@nx/vite:build",
"outputs": ["{options.outputPath}"],
"defaultConfiguration": "production",
"options": {
Expand All @@ -22,7 +22,7 @@
}
},
"serve": {
"executor": "@nrwl/vite:dev-server",
"executor": "@nx/vite:dev-server",
"defaultConfiguration": "development",
"options": {
"buildTarget": "tup-ui:build",
Expand All @@ -40,7 +40,7 @@
}
},
"preview": {
"executor": "@nrwl/vite:preview-server",
"executor": "@nx/vite:preview-server",
"defaultConfiguration": "development",
"options": {
"buildTarget": "tup-ui:build"
Expand All @@ -55,15 +55,15 @@
}
},
"test": {
"executor": "@nrwl/vite:test",
"executor": "@nx/vite:test",
"outputs": ["coverage/apps/tup-ui"],
"options": {
"passWithNoTests": true,
"reportsDirectory": "../../coverage/apps/tup-ui"
}
},
"lint": {
"executor": "@nrwl/linter:eslint",
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/tup-ui/**/*.{ts,tsx,js,jsx}"]
Expand Down
4 changes: 2 additions & 2 deletions apps/tup-ui/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": ["node"]
},
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
],
"exclude": [
"src/**/*.spec.ts",
Expand Down
4 changes: 2 additions & 2 deletions apps/tup-ui/tsconfig.spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"src/**/*.d.ts"
],
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
]
}
2 changes: 1 addition & 1 deletion apps/ui-patterns/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["plugin:@nrwl/nx/react", "../../.eslintrc.json"],
"extends": ["plugin:@nx/react", "../../.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
Expand Down
10 changes: 5 additions & 5 deletions apps/ui-patterns/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
"projectType": "application",
"targets": {
"serve": {
"executor": "@nrwl/vite:dev-server",
"executor": "@nx/vite:dev-server",
"options": {
"buildTarget": "ui-patterns:build"
}
},
"build": {
"executor": "@nrwl/vite:build",
"executor": "@nx/vite:build",
"options": {
"outputPath": "dist/apps/ui-patterns"
}
},
"preview": {
"executor": "@nrwl/vite:preview-server",
"executor": "@nx/vite:preview-server",
"defaultConfiguration": "development",
"options": {
"buildTarget": "ui-patterns:build"
Expand All @@ -32,14 +32,14 @@
}
},
"lint": {
"executor": "@nrwl/linter:eslint",
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/ui-patterns/**/*.{ts,tsx,js,jsx}"]
}
},
"test": {
"executor": "@nrwl/vite:test",
"executor": "@nx/vite:test",
"outputs": ["{workspaceRoot}/coverage/apps/ui-patterns"],
"options": {
"passWithNoTests": true
Expand Down
4 changes: 2 additions & 2 deletions apps/ui-patterns/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": ["node"]
},
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
],
"exclude": [
"jest.config.ts",
Expand Down
2 changes: 1 addition & 1 deletion libs/core-components/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["plugin:@nrwl/nx/react", "../../.eslintrc.json"],
"extends": ["plugin:@nx/react", "../../.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
Expand Down
4 changes: 2 additions & 2 deletions libs/core-components/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
"tags": [],
"targets": {
"lint": {
"executor": "@nrwl/linter:eslint",
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["libs/core-components/**/*.{ts,tsx,js,jsx}"]
}
},
"test": {
"executor": "@nrwl/vite:test",
"executor": "@nx/vite:test",
"outputs": ["coverage/libs/core-components"],
"options": {
"passWithNoTests": true,
Expand Down
4 changes: 2 additions & 2 deletions libs/core-components/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": ["node"]
},
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
],
"exclude": [
"**/*.spec.ts",
Expand Down
2 changes: 1 addition & 1 deletion libs/core-wrappers/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["plugin:@nrwl/nx/react", "../../.eslintrc.json"],
"extends": ["plugin:@nx/react", "../../.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
Expand Down
4 changes: 2 additions & 2 deletions libs/core-wrappers/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
"tags": [],
"targets": {
"lint": {
"executor": "@nrwl/linter:eslint",
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["libs/core-wrappers/**/*.{ts,tsx,js,jsx}"]
}
},
"test": {
"executor": "@nrwl/vite:test",
"executor": "@nx/vite:test",
"outputs": ["coverage/libs/core-wrappers"],
"options": {
"passWithNoTests": true,
Expand Down
4 changes: 2 additions & 2 deletions libs/core-wrappers/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": ["node"]
},
"files": [
"../../node_modules/@nrwl/react/typings/cssmodule.d.ts",
"../../node_modules/@nrwl/react/typings/image.d.ts"
"../../node_modules/@nx/react/typings/cssmodule.d.ts",
"../../node_modules/@nx/react/typings/image.d.ts"
],
"exclude": [
"**/*.spec.ts",
Expand Down
Loading

0 comments on commit 2ca4d01

Please sign in to comment.