Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(card): linked images #419

Merged
merged 4 commits into from
Oct 31, 2024
Merged

enhance(card): linked images #419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13e5caf
enhance(card): table of contents for image cards
wesleyboar Oct 31, 2024
207aea1
feat(x-link): block-link
wesleyboar Oct 31, 2024
d148178
docs(card): add linked images to demo
wesleyboar Oct 31, 2024
790c5cc
fix(card): linked image layout bugs and missing ux
wesleyboar Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(card): add linked images to demo
  • Loading branch information
@wesleyboar
wesleyboar committed Oct 31, 2024
commit d148178ceee18187ab128097ce2df54d453c6600
25 changes: 23 additions & 2 deletions src/lib/_imports/components/c-card/_c-card--image.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,27 @@

<h4><a href="#">Bender Rodríguez</a></h4>
<p>Planet Express Worker</p>
<p>Anti-hero in Futurama</p>
<p>(Anti-hero in Futurama)</p>
<p><strong>
{{#if image-link}}
Image <em>IS</em> a link
{{else}}
Image is <em>NOT</em> a link
{{/if}}
</strong></p>
{{#if image-link}}
<a href="{{image-link}}">
<img class="img-fluid" width="234px" height="293px"
src="https://cohro.ukzn.ac.za/wp-content/uploads/2019/02/profile-placeholder.png"
title="University of Texas at Austin" class="img-fluid"
/>
</a>
{{else}}
<img class="img-fluid" width="234px" height="293px"
src="https://cohro.ukzn.ac.za/wp-content/uploads/2019/02/profile-placeholder.png"
title="University of Texas at Austin" class="img-fluid"
/>
{{/if}}

{{else}}

Expand All @@ -16,7 +32,12 @@
{{#if tall}}
{{> @message tag="p" type="warning" scope="inline" content="Narrow images might not fill space available. Just use a wider image." }}
{{/if}}
{{#if image-link}}
<a href="{{image-link}}">
<img src="{{> @img-url wide=wide tall=tall medium=true }}" />
</a>
{{else}}
<img src="{{> @img-url wide=wide tall=tall medium=true }}" />

{{/if}}
{{/if}}
</article>
64 changes: 64 additions & 0 deletions src/lib/_imports/components/c-card/c-card--images.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,17 @@
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Transparent Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="transparent" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="transparent" image-link="#" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true image-link="#" }}
</section>

<h3>Plain Card Image</h3>
Expand All @@ -29,9 +37,17 @@
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Plain Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="plain" image-link="#"}}
{{> @c-card--image position="right" tall=true variant="plain" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="plain" image-link="#" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true image-link="#" }}
</section>
</section>
<hr>
Expand All @@ -44,9 +60,17 @@
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Transparent Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="transparent" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="transparent" image-link="#" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true image-link="#" }}
</section>

<h3>Plain Card Image</h3>
Expand All @@ -56,9 +80,17 @@
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Plain Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="plain" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="plain" image-link="#" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true image-link="#" }}
</section>
</section>
<hr>
Expand All @@ -71,9 +103,17 @@
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Transparent Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="transparent" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="transparent" image-link="#" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true image-link="#" }}
</section>

<h3>Plain Card Image</h3>
Expand All @@ -83,9 +123,17 @@
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Plain Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="plain" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="plain" image-link="#" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true image-link="#" }}
</section>
</section>
<hr>
Expand All @@ -98,9 +146,17 @@
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Transparent Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="transparent" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="transparent" image-link="#" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true image-link="#" }}
</section>

<h3>Plain Card Image</h3>
Expand All @@ -110,8 +166,16 @@
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Plain Card Image with Link</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="bottom" wide=true variant="plain" image-link="#" }}
{{> @c-card--image position="right" tall=true variant="plain" image-link="#" }}
{{> @c-card--image position="left" tall=true variant="plain" image-link="#" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true image-link="#" }}
</section>
</section>