Bug/WP-50: Fix sizing of buttons "as-link"

[jmcmillenmusic]

Overview

There was a bug that caused the "as-link" buttons to appear smaller than other buttons (0.78 rem as opposed to 1 rem).

Related

• WP-50

Changes

After inspecting the as-link button in question, I navigated to the file that set the font-size to 0.78 rem and adjusted it to 1 rem.

Testing

1. Log in to cep.test/workbench.
2. Navigate to the History section in the sidebar.
3. In both Jobs and Historic Jobs, the "Mark All as Viewed" as-link button should now appear bigger (16px).

UI

Notes

I created a Shared Workspace to test out the button re-sizing, and it works there, too.

[jmcmillenmusic]

Because there were commits for this PR that did not belong here, I worked with Frank to correct this. This will need to be re-reviewed even though nothing has technically changed.

[edmondsgarrett]

History link change looks good here, but this change does not address the bug directly - we are looking for any button of type='link' to have a font size of 16px, and this change will only reach this one button in the header of the History component.

I suggest taking a look at the _common Button component and how the style 'as-link' is applied to an instance of a <Button type='link' ... />.

Let me know if I can help with making this change!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (fde011b) to head (ce268ee).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #986   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files         532      532           
  Lines       33235    33235           
  Branches     2966     2966           
=======================================
  Hits        24276    24276           
  Misses       8764     8764           
  Partials      195      195           

Flag	Coverage Δ
javascript	75.98% <ø> (ø)
unittests	60.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[fnets]

Some very minor change requests, but it looks good to me! Great work!

[fnets]

LGTM! Great work.

[jalowe13]

LGTM!

[jmcmillenmusic]

History link change looks good here, but this change does not address the bug directly - we are looking for any button of type='link' to have a font size of 16px, and this change will only reach this one button in the header of the History component.

I suggest taking a look at the _common Button component and how the style 'as-link' is applied to an instance of a <Button type='link' ... />.

Let me know if I can help with making this change!

Hi, Garrett! It looks like this is blocking the merge after Jacob and Frank approved the changes.
Can you unblock this, please?

[edmondsgarrett]

LGTM! Another instance of this is in Data Files, the 'View Full Path' button, and that is also correctly styled now.

[wesleyboar]

⚠️ This change affects at least one other view (move/copy modal), because this style applies to all .as-link buttons.

fix.WP-782.mov