Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1650: Test Cases for _common/Button #640

Merged
merged 12 commits into from
Jun 14, 2022
Merged

FP-1650: Test Cases for _common/Button #640

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d5bad95
test(fp-1650): add test cases, add prop value maps
wesleyboar May 16, 2022
7499aca
chore(fp-1650): prettier fix
wesleyboar May 17, 2022
07a339f
Merge branch 'main' into task/FP-1650-button-component-test-cases
wesleyboar Jun 2, 2022
38af56b
fix(fp-1650): don't fail on empty className
wesleyboar Jun 2, 2022
ea23a26
Merge branch 'main' into task/FP-1650-button-component-test-cases
wesleyboar Jun 3, 2022
a6c81cd
fix(fp-1650): dataTestid default, '' → undefined
wesleyboar Jun 13, 2022
f2c53ea
Merge branch 'main' into task/FP-1650-button-component-test-cases
wesleyboar Jun 13, 2022
17049b0
fix(fp-1650): remove unused function
wesleyboar Jun 13, 2022
852b590
Merge branch 'task/FP-1650-button-component-test-cases' of github.com…
wesleyboar Jun 13, 2022
e80f9de
fix(fp-1650): fixes from tup-ui PR
wesleyboar Jun 13, 2022
e24a043
Revert "fix(fp-1650): fixes from tup-ui PR"
wesleyboar Jun 14, 2022
7b4e41f
Merge branch 'main' into task/FP-1650-button-component-test-cases
wesleyboar Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(fp-1650): fixes from tup-ui PR 
Source: https://github.com/TACC/tup-ui/pull/7/files#diff-7c7d6d82c4485c00f402e951eb76d77bfad3a2f3b567fa9f2330eb47a85f814a
  • Loading branch information
@wesleyboar
wesleyboar committed Jun 13, 2022
commit e80f9de1af9160ff8f73bfe906271957b0908d69
4 changes: 2 additions & 2 deletions client/src/components/_common/Button/Button.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ describe('Button', () => {
<Button data-testid="no button here">{TEST_TEXT}</Button>
);
const el = queryByTestId('no button here');
expect(el).toBeNull;
expect(el).toBeNull();
});
it('disables button when in loading state', () => {
muteTypeNotLinkNoSizeLog();
const { queryByText } = render(
<Button isLoading={true}>Loading Button</Button>
);
const el = queryByText('Loading Button');
expect(el).toBeDisabled;
expect(el).toBeDisabled();
});
});

Expand Down