Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/168: Made edits following prev pull request #231

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

juliusperez1695
Copy link
Collaborator

Pull Request Template

Description

Addressing fixes suggested following previous pull request for feature #168.

Fixes

  • Adjusted string matching to ensure only specified grants are identified as High Risk/Extremely Dangerous
  • Now flagging broad-scope grants in output csv/json files
  • Log now reports number of each risky grant found

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Individually tested Get-HawkTenantConsentGrant function and confirmed desired output

Checklist:

  • My code follows the style guidelines of Hawk
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jonnybottles jonnybottles self-requested a review January 11, 2025 11:50
@jonnybottles jonnybottles merged commit f99a3df into Development Jan 11, 2025
3 checks passed
@jonnybottles jonnybottles deleted the feature/168-high-risk-permission-id-edits branch January 11, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants