ST6RI-795 Improve performance of validation involving inherited memberships #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements performance improvements for the computation of the inherited memberships of a namespace, primarily in a set of methods in the
TypeAdapter
.Through performance profiling, it was determined that the time spent doing validation was dominated by validation checks on namespaces, functions and expressions that required the computation of inherited members. In addition, some of the most time-expensive transformations also required this computation, in order to get the inherited ends of connectors and connection usages. Improving the performance of the inheritance computation was thus seen to have a potentially high impact.
Further analysis indicated that the major performance cost in the inheritance computation was in removing memberships due to redefinition relationships. Two major changes were implemented to address this:
KerMLScope
.)As a result of these changes, the processing time for larger models can be reduced by half or more.