Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to main #115

Merged
merged 44 commits into from
Nov 30, 2022
Merged

Develop to main #115

merged 44 commits into from
Nov 30, 2022

Conversation

dcolleoni
Copy link
Contributor

No description provided.

dcolleoni and others added 30 commits November 23, 2022 10:09
* working on reports doc

* metadata

* break down utils

* remove preview

* update references to utils

* fix image paths

* reset doc around reports

* fixing test + a ton of metadata

* Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance

* Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb

* Empty commit to refresh the meta-data

* Remove all *.orig files

Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>
* Replace CalculationType with EstimateType

* Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb

* Clean up notebooks spaces

* Empty commit to refresh the meta-data

* Cleanup comments in Import/ImportStorage.ipynb

* Fix capitalization in Importers & ImportStorage NB

* Fix column order in csv

* Add blank cell DataNodeParameters link
Default aoc configuration with format
* working on links

* read me

* remove redundant code

* clean up

* AocConfiguration ImportFormat

* remove reference to init from Overview
* Adding data files

* Fix input

* Fix input

* change to importers test

* Fix to sign

* Int convention
* Overview (Template), revised text

* Reports of template with small adjustments

* Overview IFRS17, some adjustments
* Ifrs17ReportScopes

* wip

* latest

* add other reports

* start with pv

* filter does not work

* clean up

* clean up reports

* clean up

* typo

* move it ce

* remove partition set

* adjust reporting

* test readme with relative path for image

* back to absolute path - bug in the portal -

* wip

* settle with identities

* some more docs

* adding rn and period selector
* Define new ImportFormats

* Apply import w format in DN, DNS, DP, CF

* Apply import w format in A, SV and O

* Correct Import statements

* Replace abs link with var link

* Adjust naming convention

* Adjust new import format in full-template
* update packages

* add anchors
* Fixing input data

* Workaround for bm generation

* Fixed GetSign

* Inputs

* Fixed Importers

* add some doc

* fixed CU

* Dirty fix on signs

* undo CU sign

* wip

* Fix signs

* Init

* fix

* fix

* exclude simple value from test

* some partial fix

* Full fix
* included back AggregateBy

* included Currency column in ReportVariable benchmarks
* remove spec tests

* read me and big picture

* help review

* code of conduct. Readme. Remove Spec tests

* env for go live

* rename of directories in file

* overview template

* improve template readme

* calculation engine and reports in template

* more on ifrs17ce

* NB titles

* clean up display order

* improve validation

* fix links

* fix link

* Close import template

* additions to report guide

* solve conflicts
Partitions are handled automatically
* forbiddenSlices and chose init or db connection

* clean ups

* small letters to capital

* complete sentence about filters
* Use AmountType instead of PvAmountType

* Filter out DeferrableAmountType
nnikolopoulos and others added 14 commits November 29, 2022 15:34
* New metadatax2

* Undo changes in CalculationEngine NB

* Undo changes in CalculationEngine NBx2
* Input Data

* Inputs

* remove all the AA OA stuff from CSM and PL

* Adding WO in FP

* Adding BOP N to the delta in LRC/LIC reports

* signs

* flipping WO sign in FP

* Adding Over example

* adjust examples

* docu

* last example

* Last corrections

* Update ref BM

* Some changes to BM generation

* Adding RI

* OverviewCalculationEngine

* Correct APA

* More test data

* signs of Ri

* Bm sorting

* RV bm

* Text

* BM

* test update

* Metadata

* Fix merge

* fix OverviewCalculationEngine

* Fix
* Uploading the files to start working with.

* Finsihing with the second video, up to some corrections coming up.

* Finishing the notebook for the third video.

* Work on readme

* some commit

* Updating to the newest calculation engine, updating readme.

* simpler names + no mandatory accidentYear

* better

* fix Application Message

* better x2

* compute discount and cumulate

* implement feedback

* improve overall

* aoc configuration

* better importers

* reset and initialize only once

* solve remaining merge conflict

* revisions for signs + new overview

* metadata + fix importers validate datanode

* extra type + utils reports

* implement all feedback

* updated links YT

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* Update Reports.ipynb

There was an issue in line 73 with the metadata

* Update Reports.ipynb
* Input Data

* Inputs

* remove all the AA OA stuff from CSM and PL

* Adding WO in FP

* Adding BOP N to the delta in LRC/LIC reports

* signs

* flipping WO sign in FP

* Adding Over example

* adjust examples

* docu

* last example

* Last corrections

* Update ref BM

* Some changes to BM generation

* Adding RI

* OverviewCalculationEngine

* Correct APA

* More test data

* signs of Ri

* Bm sorting

* RV bm

* improvements

* little improvements

* downloading - metadata and indent

* more on readme + clean up

* implement pr feedbacks

* remove Full from path and project name

* rename project directory

* main readme

* typos

* test cdn pic

* Update README.md

* readme - pic links

* Full

* remove not necessary pics + update 2 links

* links

* links

* link

* cash flow convention

* ifrs17 workd convention

* AoC

* take out slices and correct suggestion

* read me + remove Cf complex

* PV Base

* pv add test

* add a title to tests

* Init Ref Data

* pr comment

* locked in rates - end of inception year

* template youtube video

* fix

* some more

* AoC step in pv

* improve OverviewCalculationEngine

* comments

* comment

Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
* updated links

* actuals mtup moved to test

* fix scenario test with testing+ init for testing

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* Adding new workspaces where needed.

* Changing last Workspaces to workspaces.

* restore metadata

* fix data node state validation + cleanups

* fix text

* fix text part 2

Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
* Making a separate section for every Import Format.

* A typo.

* Removed subsections from formats.

* Deleting duplicated text and updating "MapTemplateAndImportTest."

* Adding the missing link to Systemorph webpage.

* Semicolon in the DataFilter.
* readme ce and init of PV

* ifrs17 ce

* YieldCurveName

* from public

* fixed MapTemplateAndImportTest

* .any

Co-authored-by: Sara Busato <sbusato@systemorph.com>
# Conflicts:
#	LICENSE
#	README.md
#	full-ifrs17-template/LICENSE
#	ifrs17-template/LICENSE
#	ifrs17/CalculationEngine.ipynb
#	ifrs17/Constants/Consts.ipynb
#	ifrs17/Constants/Enums.ipynb
#	ifrs17/Constants/Validations.ipynb
#	ifrs17/DataModel/DataStructure.ipynb
#	ifrs17/Export/ExportConfiguration.ipynb
#	ifrs17/Import/ImportScopeCalculation.ipynb
#	ifrs17/Import/ImportStorage.ipynb
#	ifrs17/Import/Importers.ipynb
#	ifrs17/OverviewCalculationEngine.ipynb
#	ifrs17/README.md
#	ifrs17/Report/ReportConfigurationAndUtils.ipynb
#	ifrs17/Report/ReportMutableScopes.ipynb
#	ifrs17/Report/ReportScopes.ipynb
#	ifrs17/Report/ReportStorage.ipynb
#	ifrs17/Test/AocConfigurationTest.ipynb
#	ifrs17/Test/QueriesTest.ipynb
#	ifrs17/Test/Tests.ipynb
#	ifrs17/Utils/ApplicationMessage.ipynb
#	ifrs17/Utils/EqualityComparers.ipynb
#	ifrs17/Utils/Extensions.ipynb
#	ifrs17/Utils/ImportCalculationMethods.ipynb
#	ifrs17/Utils/Queries.ipynb
#	ifrs17/Utils/TestHelper.ipynb
@dcolleoni dcolleoni added this to the Go-live milestone Nov 30, 2022
@dcolleoni dcolleoni requested a review from dtrzesniak November 30, 2022 20:18
@dcolleoni dcolleoni self-assigned this Nov 30, 2022
@dcolleoni dcolleoni merged commit ea6c6df into main Nov 30, 2022
@dcolleoni dcolleoni deleted the developToMain branch November 30, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants