Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change theme in example-config.el to doom-one #131

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Change theme in example-config.el to doom-one #131

merged 2 commits into from
Apr 25, 2022

Conversation

sthesing
Copy link
Contributor

In its current state, starting a fresh install of rational emacs with the example config fails.
One reason is that it tries to load doom-snazzy, which isn't available the last versioned release of doom-themes.

doom-one has a similar look and is available.

`doom-snazzy` isn't available after a fresh install.
@jeffbowman
Copy link
Contributor

Looks good. Unfortunately, there are 2 instances of this file, the one you changed and a duplicate in examples/general/example-config.el which needs the same fix. Would you mind adding that to your PR?

@sthesing
Copy link
Contributor Author

Oh, I overlooked that. Thanks for pointing it out. I'll amend the PR.
I grepped through the repo and found more mentions of doom-snazzy in the docs directory. Does it make sense to change these, too? Or are the generated from the example configs, anyway?

@jeffbowman
Copy link
Contributor

It makes sense to change those as well. Thanks for finding them!

in examples, README and docs.
@sthesing
Copy link
Contributor Author

It makes sense to change those as well. Thanks for finding them!

OK, thanks for getting back to me with that. Changed all of them. Including README

@jeffbowman jeffbowman merged commit a58fe88 into SystemCrafters:master Apr 25, 2022
@jeffbowman
Copy link
Contributor

Thanks very much!

@sthesing sthesing deleted the fix-snazzy branch April 25, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants