Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BCKDH Genes and Remove Mito & Nuc Thiocyanate <-> Hypothiocyanite Reactions #750

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Dec 8, 2023

Main improvements in this PR:

As proposed in #742:

  • Adds ENSG00000137992 to the GPRs of MAR06416, MAR06419, and MAR06421
  • Removes MAR02532 and MAM02158m
  • Removes MAR02534, MAM02158n, and MAM02986n
  • Removes ENSG00000130508 and ENSG00000117592 from the GPR of MAR06523
  • Adds PMID:11013238 and PMID:31989833 to the list of references for MAR06523
  • Removes ENSG00000142046 from the GPRs of MAR06416, MAR06419, MAR06421, and MAR06523 as well as the list of genes in Human-GEM

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer
Copy link
Collaborator Author

ah whoops; the validation is failing because I removed the gene entry for TMEM91 (ENSG00000142046) but it's still in the GPRs of MAR03748 and MAR03780, which I missed because I removed those in #743 and forgot that that wasn't merged yet. We can either

  1. wait until Fix Duplicate BCKDH Reactions #743 is merged into develop then merge develop into here
  2. also remove TMEM91 from the GPRs of MAR03748 and MAR03780 in this PR

@haowang-bioinfo
Copy link
Member

would prefer to option1 that makes things easier

@Devlin-Moyer
Copy link
Collaborator Author

Apparently MAR02352 and MAR02354 were the only reactions that thiocyanate (MAM2986) or hypothiocyanite (MAM02158) were involved in in the mitochondrial and nuclear compartments, respectively; I'm just going to remove those metabolites, since they also exist in other compartments where there is evidence to support their existence (namely the cytosol and lysosome)

@Devlin-Moyer Devlin-Moyer changed the title Fix BCKDH Genes Fix BCKDH Genes, Remove Mito & Nuc Thiocyanate <-> Hypothiocyanite Reactions Dec 10, 2023
@Devlin-Moyer Devlin-Moyer changed the title Fix BCKDH Genes, Remove Mito & Nuc Thiocyanate <-> Hypothiocyanite Reactions Fix BCKDH Genes and Remove Mito & Nuc Thiocyanate <-> Hypothiocyanite Reactions Dec 10, 2023
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@haowang-bioinfo haowang-bioinfo merged commit cee575c into develop Dec 18, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/BCKDH_genes branch December 18, 2023 16:46
@JHL-452b JHL-452b mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants